[MV3 Debug Extension] Support Bolt workflow #1983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
commented
Feb 22, 2023
|
|
||
| DwdsInjector( | ||
| this._loadStrategy, { | ||
| required bool enableDevtoolsLaunch, |
There was a problem hiding this comment.
DwdsInjector is only called from DWDS itself (here: https://github.com/dart-lang/webdev/pull/1983/files#diff-e56f8e114cfd5b74f48f729657275d651f1625eaf2ab0bf85463e6d602335047L122). All of the parameters passed in have default values in DWDS itself, therefore we use those values instead of setting the defaults in two places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Bolt workflow for the new debug extension. The Dart frame is embedded in an IFRAME, so we need to make sure to connect to the correct frame.
See #1779 (comment) for details on why there is no test (added TODO).