Skip to content

[MV3 Debug Extension] Ignore page reloads for detecting navigation away from app #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023
Merged

[MV3 Debug Extension] Ignore page reloads for detecting navigation away from app #1994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b885f
Ignore page reloads for dismounting extension
elliette Feb 27, 2023
2a15405
Update comment
elliette Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dwds/debug_extension_mv3/web/background.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ Future<void> _handleRuntimeMessages(
Future<void> _detectNavigationAwayFromDartApp(
NavigationInfo navigationInfo) async {
// Ignore any navigation events within the page itself (e.g., opening a link,
// reloading an IFRAME, etc):
// reloading the page, reloading an IFRAME, etc):
if (_isInternalNavigation(navigationInfo)) return;
final tabId = navigationInfo.tabId;
final debugInfo = await _fetchDebugInfo(navigationInfo.tabId);
Expand All @@ -163,6 +163,7 @@ bool _isInternalNavigation(NavigationInfo navigationInfo) {
'form_submit',
'link',
'manual_subframe',
'reload',
].contains(navigationInfo.transitionType);
}

Expand Down