Skip to content

Create a Dart Debug Extension issue template #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2023
Merged

Create a Dart Debug Extension issue template #2014

merged 2 commits into from
Mar 4, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Mar 3, 2023

Follow up to #1979

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Mar 3, 2023
@elliette elliette requested a review from devoncarew March 3, 2023 21:31
@elliette
Copy link
Contributor Author

elliette commented Mar 3, 2023

Adding Devon as reviewer, Anna is OOO today. Thanks!

devoncarew
devoncarew approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Note that this will be slightly asymmetric w/ the existing three templates (which are all for package: packages). I'm sure you're aware, just mentioning for completeness. Consider also updating the PR labeler file in .github/ to apply a 'dart-debug-extension' to PRs w/ matching file paths.

I see that the code for the debug extension is is a subdir of the webdev/ dir. Is this useful? necessary? historic? Or could that be refactored to a new top-level dir?

@elliette
Copy link
Contributor Author

elliette commented Mar 3, 2023

Consider also updating the PR labeler file in .github/ to apply a 'dart-debug-extension' to PRs w/ matching file paths.

Done!

I see that the code for the debug extension is is a subdir of the webdev/ dir. Is this useful? necessary? historic? Or could that be refactored to a new top-level dir?

This is purely historic, opened up #2016 for the refactor.

@elliette elliette merged commit eb63b31 into dart-lang:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @devoncarew