Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an app entrypoint to DWDS #2047

Merged
merged 17 commits into from
Mar 30, 2023
Merged

Provide an app entrypoint to DWDS #2047

merged 17 commits into from
Mar 30, 2023

Conversation

elliette
Copy link
Collaborator

@elliette elliette commented Mar 22, 2023 •
edited
Loading

Work towards flutter/devtools#5350

Requires the following changes to Flutter: flutter/flutter@master...elliette:dwdsEntrypoint

@elliette elliette marked this pull request as ready for review March 24, 2023 00:12
@elliette elliette changed the title [WIP] Provide an app entrypoint to DWDS Provide an app entrypoint to DWDS Mar 24, 2023
@elliette elliette requested a review from annagrin March 24, 2023 00:12
annagrin
annagrin reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elliott, added a comment.

dwds/lib/src/debugging/inspector.dart Outdated
@@ -136,6 +136,7 @@ class AppInspector implements AppInspectorInterface {
String root,
Debugger debugger,
ExecutionContext executionContext,
LoadStrategy loadStrategy,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw we have the load strategy available as a globalLoadStrategy (set on dwds.start so we don't need to pass it around. Can we switch to using the global in this PR as well? Alternatively, we can move to passing load strategy everywhere (not sure the work involved is justifiable though).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

annagrin
annagrin approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small comment

dwds/test/fixtures/context.dart Outdated Show resolved Hide resolved
annagrin
annagrin approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette
Copy link
Collaborator Author

Adding @christopherfujino as well

This is a breaking change and will require the following change in flutter_tools when updating to the next version of DWDS: flutter/flutter@master...elliette:dwdsEntrypoint

@elliette elliette removed the request for review from christopherfujino March 30, 2023 22:59
@elliette
Copy link
Collaborator Author

Adding @christopherfujino as well

This is a breaking change and will require the following change in flutter_tools when updating to the next version of DWDS: flutter/flutter@master...elliette:dwdsEntrypoint

Chris is OOO, will hold off until next week to release new version.

@elliette elliette merged commit 652e040 into dart-lang:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagrin annagrin annagrin approved these changes

Assignees
No one assigned
Labels
package:dwds package:webdev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elliette @annagrin