Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shard MV2 and MV3 extension tests #2153

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Shard MV2 and MV3 extension tests #2153

merged 4 commits into from
Jun 22, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jun 21, 2023 •
edited
Loading

Moves the extension test cases into extension_common so that the MV2 and MV3-specific tests can be sharded into separate files.

Work towards #1787

@elliette elliette marked this pull request as draft June 21, 2023 21:12
@elliette elliette requested a review from annagrin June 22, 2023 17:31
@elliette elliette marked this pull request as ready for review June 22, 2023 17:31
annagrin
annagrin approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 8360d50 into dart-lang:master Jun 22, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagrin annagrin annagrin approved these changes

Assignees
No one assigned
Labels
changelog-not-required package:dwds run-dcm-workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elliette @annagrin