Skip to content

[webdev] Hide --null-safety option #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

parlough
Copy link
Member

This flag is confusing now that webdev requires a Dart 3 SDK which doesn't support unsound null safety. To reduce this confusion, this PR hides the --null-safety flag from the output help messages.

I was going to remove use of the flag entirely, but I wasn't sure if the flag is still used internally somehow. Let me know if it doesn't need to be wired up and I'd be happy to remove it :)

@parlough parlough changed the title [webdev] Hide null-safety option [webdev] Hide --null-safety option Aug 31, 2023
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@parlough
Copy link
Member Author

parlough commented Sep 7, 2023

Thanks for taking a look! Feel free to merge if you're happy with the PR, as I don't have merge access on this repo.

@elliette
Copy link
Contributor

elliette commented Sep 8, 2023

Thanks! I'll working on merging this and the other open PRs once the DWDS/WebDev releases have been completed

@elliette elliette merged commit 6f28243 into dart-lang:master Sep 11, 2023
@parlough parlough deleted the misc/hide-null-safety-option branch September 11, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants