Skip to content

Bump package:vm_service to ^12.0.0 #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2023
Merged

Bump package:vm_service to ^12.0.0 #2248

merged 6 commits into from
Oct 13, 2023

Conversation

bkonyi
Copy link
Collaborator

@bkonyi bkonyi commented Oct 11, 2023

No description provided.

@bkonyi bkonyi requested review from annagrin and elliette October 11, 2023 21:19
elliette
elliette reviewed Oct 11, 2023
View reviewed changes
elliette
elliette requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Do you mind also updating the CHANGELOG? (You can modify the existing line Update the interface for ChromeProxyService.getSourceReport to match the VM service to include the version)

@bkonyi bkonyi merged commit 8d48d5e into master Oct 13, 2023
@bkonyi bkonyi deleted the vm_service_12.0.0 branch October 13, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

@annagrin annagrin Awaiting requested review from annagrin

Assignees
No one assigned
Labels
package:dwds package:webdev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkonyi @elliette