[ DWDS ] Serve DevTools from DDS by default #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to reduce the number of ways DevTools is served across the ecosystem, we're working on serving DevTools from DDS by default in all tools that spawn DDS. This change exposes some new DDS related configuration options that allow for specifying whether or not DevTools should be served via DDS and whether or not an existing DevTools server should be used. The `devToolsLauncher` parameter has been marked as deprecated as it will be removed in a future major release, but will continue to act as the default way to launch DevTools if it is provided. Other DDS related properties that have been merged into the new `DartDevelopmentServiceConfiguration` class are also marked as deprecated.
github-actions
bot
added
package:dwds
dart-debug-extension
and removed
prepare-release
labels
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
srujzs
approved these changes
Aug 28, 2025
| bool? serveDevTools, | ||
| Uri? devToolsServerAddress, | ||
| }) { | ||
| return DartDevelopmentServiceConfiguration( |
There was a problem hiding this comment.
Is it not valid for a user to pass null for port and devToolsServerAddress and the fields to be set to null?
There was a problem hiding this comment.
Fair point. I'm just going to remove this and reconstruct the DartDevelopmentServiceConfiguration instance manually since this is only relevant until the deprecated properties are removed.
|
Landing on red due to flaky tests. |
jensjoha
added a commit
to jensjoha/webdev
that referenced
this pull request
Sep 2, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 2, 2025
…, webdev, webdriver Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/a9eb685..1547a83): 1547a83 2025-08-29 Jaime Wren Fix the capitalization of the Cursor editor in the flag description (dart-lang/ai#276) core (https://github.com/dart-lang/core/compare/b59ecf4..5c3e2c3): 5c3e2c38 2025-09-02 dependabot[bot] Bump actions/checkout from 4.2.2 to 5.0.0 in the github-actions group (dart-lang/core#904) ecosystem (https://github.com/dart-lang/ecosystem/compare/fd28be2..d6370fb): d6370fb 2025-08-31 Daco Harkes [health] Bump dart_apitool (dart-lang/ecosystem#367) i18n (https://github.com/dart-lang/i18n/compare/9a211d1..a62bed2): a62bed2c 2025-09-01 dependabot[bot] Bump actions/download-artifact in the github-actions group (dart-lang/i18n#1007) protobuf (https://github.com/dart-lang/protobuf/compare/765ba8a..0a13935): 0a13935 2025-09-02 dependabot[bot] Bump actions/checkout from 4.2.2 to 5.0.0 (google/protobuf.dart#1046) shelf (https://github.com/dart-lang/shelf/compare/400fc39..de91a5b): de91a5b 2025-09-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/shelf#481) sync_http (https://github.com/dart-lang/sync_http/compare/c07f96f..6666fff): 6666fff 2025-09-02 dependabot[bot] Bump actions/checkout from 4.2.2 to 5.0.0 (google/sync_http.dart#56) web (https://github.com/dart-lang/web/compare/e7895bd..bdab462): bdab462 2025-09-01 dependabot[bot] Bump actions/checkout from 4.2.2 to 5.0.0 in the github-actions group (dart-lang/web#462) d93ce7b 2025-08-29 Nikechukwu [web_generator] Updated README (dart-lang/web#461) webdev (https://github.com/dart-lang/webdev/compare/a7d3d2f..bf7b1e5): bf7b1e59 2025-09-02 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/webdev#2684) 769a0568 2025-08-29 Ben Konyi [ DWDS ] Serve DevTools from DDS by default (dart-lang/webdev#2681) webdriver (https://github.com/google/webdriver.dart/compare/595649d..09104f4): 09104f4 2025-09-02 dependabot[bot] Bump actions/checkout from 4.2.2 to 5.0.0 (google/webdriver.dart#332) 5fbbbaa 2025-09-02 dependabot[bot] Bump nanasess/setup-chromedriver (google/webdriver.dart#333) Change-Id: Ib6275cc21e3a989142c46b59b1005277f3621db1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448222 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the number of ways DevTools is served across the ecosystem, we're working on serving DevTools from DDS by default in all tools that spawn DDS.
This change exposes some new DDS related configuration options that allow for specifying whether or not DevTools should be served via DDS and whether or not an existing DevTools server should be used.
The
devToolsLauncherparameter has been marked as deprecated as it will be removed in a future major release, but will continue to act as the default way to launch DevTools if it is provided. Other DDS related properties that have been merged into the newDartDevelopmentServiceConfigurationclass are also marked as deprecated.