Pass script uri for javascript expression compilation #2682
Conversation
jensjoha
force-pushed
the
script_url_2025
branch
2 times, most recently
from
009e734 to
6eeba23
Compare
|
I don't know if there's any process for bumping major versions and/or min dart sdk --- this does both (and as a consequence of going from language version 3.7 to 3.10 most of the changes are formatting --- would it make more sense to land a min sdk change with a formatting first? |
Yeah, let's land a formatting change first. I have a WIP PR that I'll pick up to do that. |
|
Let's wait for #2662 to land. |
|
Please send a ping when the formatting changes are landed and this is rebased so this change is easier to review. Thanks :) |
|
Sorry for the delay on the formatting PR @jensjoha. We should be good to move forward with this PR now! |
…on compilation in parts.
…nthing and not release
jensjoha
force-pushed
the
script_url_2025
branch
from
6eeba23 to
b0c141b
Compare
|
@bkonyi thanks. I've rebased this PR. |
dwds/test/evaluate_parts_common.dart
Outdated
| } | ||
|
|
||
| await service.streamListen('Debug'); | ||
| stream = service.onEvent('Debug'); |
There was a problem hiding this comment.
| stream = service.onEvent('Debug'); | |
| stream = service.onDebugEvent; |
There was a problem hiding this comment.
It definitely should: https://pub.dev/documentation/vm_service/latest/vm_service/VmService/onDebugEvent.html
Pass over the script uri (which when in parts is different from the library uri) when doing js expression evaluation.