Properly set the pauseEvent #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-knight
approved these changes
Sep 5, 2019
| ..kind = EventKind.kBreakpointAdded | ||
| Event( | ||
| kind: EventKind.kBreakpointAdded, | ||
| timestamp: DateTime.now().millisecondsSinceEpoch) |
There was a problem hiding this comment.
We do a lot of these. If we've got our own Event subclass, maybe it could just set the timestamp and the isolate automatically?
There was a problem hiding this comment.
A couple locations we share the timestamp with other events so I'm going to keep it as is for now.
This was referenced Apr 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #629
EventandStackobjectsRunResponsewhich is used to properly set the Isolate statepauseEventstate onIsolatecreationDart2JS"require"instead ofrequire