Skip to content

Conversation

rafamizes
Copy link
Member

Closes #12

@rafamizes rafamizes added the feature New feature or request label Oct 9, 2021
@rafamizes rafamizes self-assigned this Oct 9, 2021
@rafamizes rafamizes requested a review from dartoosdev October 9, 2021 20:48
@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #13 (ac6dace) into master (c083a36) will increase coverage by 27.35%.
The diff coverage is 98.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #13       +/-   ##
===========================================
+ Coverage   62.96%   90.32%   +27.35%     
===========================================
  Files           3        5        +2     
  Lines          27       93       +66     
===========================================
+ Hits           17       84       +67     
+ Misses         10        9        -1     
Impacted Files Coverage Δ
lib/src/rand.dart 100.00% <ø> (ø)
lib/src/bytes.dart 80.00% <80.00%> (ø)
lib/src/base64/base64.dart 100.00% <100.00%> (ø)
lib/src/future_wrap.dart 27.27% <100.00%> (+2.27%) ⬆️
lib/src/text.dart 100.00% <100.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c083a36...ac6dace. Read the comment docs.

Copy link
Member

@dartoosdev dartoosdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is ok.

@dartoosdev
Copy link
Member

@rultor merge it.

@rultor
Copy link
Collaborator

rultor commented Oct 9, 2021

@rultor merge it.

@dartoosdev Thanks for your request. @rafamizes Please confirm this.

@rafamizes
Copy link
Member Author

@rultor merge it.

@rultor
Copy link
Collaborator

rultor commented Oct 9, 2021

@rultor merge it.

@rafamizes OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit ac6dace into dartoos-dev:master Oct 9, 2021
@rafamizes rafamizes deleted the feat/base64 branch October 9, 2021 21:01
@rultor
Copy link
Collaborator

rultor commented Oct 9, 2021

@rultor merge it.

@rafamizes Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base64 and Base64Url encoding schemes
4 participants