Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shape type and color options to PointCloudShape #1314

Merged
merged 2 commits into from May 15, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 14, 2019

This PR enables PointCloudShape to specify the color and the shape type.

image
image
image


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 14, 2019
@jslee02 jslee02 marked this pull request as ready for review May 14, 2019 03:21
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #1314 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
- Coverage   57.16%   57.13%   -0.04%     
==========================================
  Files         366      366              
  Lines       27025    27055      +30     
==========================================
+ Hits        15449    15457       +8     
- Misses      11576    11598      +22
Impacted Files Coverage Δ
dart/dynamics/PointCloudShape.hpp 0% <ø> (ø) ⬆️
dart/dynamics/PointCloudShape.cpp 0% <0%> (ø) ⬆️
dart/dynamics/Skeleton.cpp 66.12% <0%> (+0.16%) ⬆️
dart/dynamics/EulerJoint.cpp 70.73% <0%> (+3.04%) ⬆️

@jslee02 jslee02 requested a review from mxgrey May 14, 2019 13:20
@jslee02 jslee02 merged commit 8faf0f3 into master May 15, 2019
@jslee02 jslee02 deleted the colored_point_cloud branch May 15, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant