Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pybind wrappers for BodyNode's getChildBodyNode() & getChildJoint() #1387

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

chhinze
Copy link
Contributor

@chhinze chhinze commented Aug 12, 2019

  • Add pybind11 wrapper for getChildBodyNode(szd::size_t index) -> BodyNode*
  • Add pybind11 wrapper for getChildJoint(szd::size_t index) -> Joint*
  • Add unit test, verifying that the new wrappers work

Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #1387 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1387   +/-   ##
=======================================
  Coverage   57.27%   57.27%           
=======================================
  Files         366      366           
  Lines       27432    27432           
=======================================
  Hits        15711    15711           
  Misses      11721    11721

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 12, 2019
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution!

@jslee02 jslee02 merged commit 15b5af8 into dartsim:master Aug 12, 2019
@chhinze
Copy link
Contributor Author

chhinze commented Aug 12, 2019

Thank you for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants