Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support new if() IN_LIST operator in DARTConfig.cmake #1434

Merged
merged 5 commits into from
Feb 24, 2020
Merged

Add support new if() IN_LIST operator in DARTConfig.cmake #1434

merged 5 commits into from
Feb 24, 2020

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Feb 19, 2020 •
edited
Loading

Fixes #1429

Before creating a pull request

  • [N/A] Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • [N/A] Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Feb 19, 2020
@jslee02 jslee02 marked this pull request as ready for review February 19, 2020 01:17
@jslee02 jslee02 mentioned this pull request Feb 19, 2020
Closed
2 tasks
@codecov
Copy link

codecov bot commented Feb 19, 2020 •
edited
Loading

Codecov Report

Merging #1434 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage      58%   57.99%   -0.02%     
==========================================
  Files         412      412              
  Lines       29861    29861              
==========================================
- Hits        17322    17319       -3     
- Misses      12539    12542       +3
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.16% <0%> (-0.17%) ⬇️

@jslee02 jslee02 changed the title Set CMP0075 to new to support new if() IN_LIST operator Add support new if() IN_LIST operator in DARTConfig.cmake Feb 22, 2020
@jslee02
Copy link
Member Author

jslee02 commented Feb 22, 2020 •
edited
Loading

Building test on Windows is failing due to other reasons as master is failing as well.

@jslee02 jslee02 merged commit df79cde into master Feb 24, 2020
@jslee02 jslee02 deleted the bugfix/if_in_list branch February 24, 2020 17:05
scpeters added a commit to scpeters/dart that referenced this pull request Aug 30, 2020
@scpeters
Use approach from dartsim#1434
fc749f6
jslee02 pushed a commit that referenced this pull request Aug 30, 2020
@scpeters
Support IN_LIST operator in DARTConfig.cmake (6.9 backport) (#1494)
0ef9fd3 
* DARTFindBullet: set CMP0057 to new

The IN_LIST keyword in DARTFindBullet caused a configuration
error in gazebo10. Setting CMP0057 to new should prevent
similar problems in downstream packages.

* Use approach from #1434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.10.0
Development

Successfully merging this pull request may close these issues.

CMake Error in FindBullet
1 participant
@jslee02