Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CONFIG mode to find DART in examples and tutorials #889

Merged
merged 1 commit into from May 21, 2017

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 21, 2017

find_package(DART) uses FindDart.cmake of the DART programming language by default. This PR changes the DART examples and tutorials to use CONFIG mode instead to find our DART using DARTConfig.cmake.

This PR resolves #888.

@jslee02 jslee02 added this to the DART 6.2.1 milestone May 21, 2017
@jslee02 jslee02 changed the base branch from master to release-6.2 May 21, 2017 18:07
@codecov
Copy link

codecov bot commented May 21, 2017

Codecov Report

Merging #889 into release-6.2 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-6.2     #889   +/-   ##
============================================
  Coverage        50.59%   50.59%           
============================================
  Files              299      299           
  Lines            23408    23408           
  Branches          3015     3015           
============================================
  Hits             11843    11843           
  Misses           10236    10236           
  Partials          1329     1329

@jslee02 jslee02 merged commit 0a668d9 into release-6.2 May 21, 2017
@jslee02 jslee02 deleted the bugfix/find_dart branch May 21, 2017 19:56
@psigen
Copy link
Collaborator

psigen commented May 24, 2017 via email

@jslee02
Copy link
Member Author

jslee02 commented May 24, 2017

This might be fine on Linux because Linux is a case-sensitive system (not that the DART language uses "Dart" while we use "DART"). But on macOS this could be an issue as you pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants