-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow adding non-unique indices for newly defined properties #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Dec 14, 2021
...tateTransition/DataContractUpdateTransition/validation/basic/validateIndicesAreNotChanged.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 14, 2021
...tateTransition/DataContractUpdateTransition/validation/basic/validateIndicesAreNotChanged.js
Outdated
Show resolved
Hide resolved
shumkov
requested changes
Dec 22, 2021
...sition/DataContractUpdateTransition/validation/basic/validateIndicesAreBackwardCompatible.js
Outdated
Show resolved
Hide resolved
...sition/DataContractUpdateTransition/validation/basic/validateIndicesAreBackwardCompatible.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Dec 28, 2021
...sition/DataContractUpdateTransition/validation/basic/validateIndicesAreBackwardCompatible.js
Outdated
Show resolved
Hide resolved
This pull request introduces 4 alerts when merging 1bab5bc into b566168 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 868ab77 into f0c1077 - view on LGTM.com new alerts:
|
shumkov
approved these changes
Dec 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Adding an ability to add non-unique indices for newly defined properties.
What was done?
validateIndicesAreNotChanged
functionHow Has This Been Tested?
Unit tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only