Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow adding non-unique indices for newly defined properties #83

Merged
merged 15 commits into from
Dec 31, 2021

Conversation

jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Dec 14, 2021

Issue being fixed or feature implemented

Adding an ability to add non-unique indices for newly defined properties.

What was done?

  • updated validateIndicesAreNotChanged function

How Has This Been Tested?

Unit tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.22.0 milestone Dec 14, 2021
@jawid-h jawid-h requested a review from shumkov December 15, 2021 10:12
@jawid-h jawid-h requested a review from shumkov December 27, 2021 14:19
@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2021

This pull request introduces 4 alerts when merging 1bab5bc into b566168 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 30, 2021

This pull request introduces 4 alerts when merging 868ab77 into f0c1077 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@jawid-h jawid-h requested a review from shumkov December 30, 2021 13:56
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@jawid-h jawid-h merged commit c42d58d into v0.22-dev Dec 31, 2021
@jawid-h jawid-h deleted the feat/non-unique-indices branch December 31, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants