Skip to content

chore: synchronize packages dependency versions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 4, 2021
Merged

chore: synchronize packages dependency versions #1

merged 14 commits into from
Nov 4, 2021

Conversation

antouhou
Copy link
Contributor

@antouhou antouhou commented Nov 3, 2021 •
edited
Loading

Issue being fixed or feature implemented

The build doesn't work because different packages use different versions of dependencies

What was done?

Synchronized dependency versions across all packages

How Has This Been Tested?

Run the build and run dashmate

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title feat: prepare repository for work chore: prepare repository for work Nov 3, 2021
Konstantin Shuplenkov added 2 commits November 3, 2021 18:13
Merge branch 'master' into feat-prepare-for-work
e8c4f1a 
# Conflicts:
#	packages/js-dash-sdk/package-lock.json
#	packages/js-dash-sdk/package.json
#	packages/js-dpp/package-lock.json
#	packages/js-dpp/package.json
chore: update lock files
1b7ad99
@shumkov shumkov changed the title chore: prepare repository for work chore: prepare packages Nov 3, 2021
@antouhou antouhou changed the title chore: prepare packages chore: synchronize packages versions Nov 4, 2021
@antouhou antouhou changed the title chore: synchronize packages versions chore: synchronize packages dependency versions Nov 4, 2021
@antouhou antouhou marked this pull request as ready for review November 4, 2021 10:49
shumkov
shumkov approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov shumkov merged commit 9097962 into master Nov 4, 2021
@shumkov shumkov deleted the feat-prepare-for-work branch November 4, 2021 12:42
jawid-h added a commit that referenced this pull request Dec 27, 2021
@jawid-h
chore: additional validation #1
14d3a97
jawid-h added a commit that referenced this pull request Dec 27, 2021
@jawid-h
chore: additional validation #1
2770614
@shumkov shumkov added this to the v0.21.x milestone Feb 1, 2022
shumkov pushed a commit that referenced this pull request Nov 23, 2022
@QuantumExplorer
Merge pull request #1 from dashevo/wisdom/fixes
1813814 
fixes (wip)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@shuplenkov shuplenkov Awaiting requested review from shuplenkov

@jawid-h jawid-h Awaiting requested review from jawid-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.x
Development

Successfully merging this pull request may close these issues.
2 participants
@antouhou @shumkov