Allow compilation with --disable-wallet
#1733
Conversation
UdjinM6
force-pushed
the
fix1732
branch
2 times, most recently
from
343e3b3
to
47646ab
Compare
|
Can't compile it with --disable-wallet. I have several linking errors. For example, masternode.cpp should be part of dashd without wallet, as far as I understand, but it contains reference to pMainWallet: https://github.com/dashpay/dash/blob/47646abf07b23861231dd473c77445a57a7cfae7/src/masternode.cpp#L381, so I has linking error. After getting the sources from this PR I'm doing |
|
Thanks! Wasn't failing on my mac but I was able to reproduce this on Ubuntu... Should be fixed by 2b4ade7 , pls try again |
|
ACK. I've compiled it, have started dashd and have posted several rpc calls, all is working now (Ubuntu 17) |
|
Rebased to fix merge conflict in |
|
ACK |
…es affected by this change
…s affected by this change
|
I figured out that we can also (finally) re-enable Travis build with no wallet which was disabled for almost 2 years now 🙈 Trying to do so revealed more references that had to be fixed which in their turn required quite a few other files to be fixed too. Organized these changes in 2 new commits, groped by the initially fixed reference. 3rd commit is simply removing |
|
ACK, have builded it locally, synced with net, call several rpc methods, wallet rpc calls are not available, other calls works correctly, GUI client hasn't wallet-related tabs, all is correct. |
|
ACK, have builded it locally, running as masternode on testnet , working fine. |
* Allow compilation with `--disable-wallet` * fix remaining references * Drop wallet references/include in CActiveMasternode and fix other files affected by this change * Wrap privatesend-client.h include with ifdef/endif and fix other files affected by this change * Re-enable Travis build with no wallet reverts 267e578
Should fix #1732, please test.