Split sentinel expiration in CMasternode::Check() in two parts (timeout and version) #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut and version) The initial ping is sent with defaults which switch MNs to SENTINEL_PING_EXPIRED state while they should really be in PRE_ENABLED state. The fix is to split this verification in two parts - this way sentinel version is only checked after at least one ping is received from the masternode itself and not from the cold wallet.
nmarley
approved these changes
Jun 18, 2018
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…ut and version) (dashpay#2121) The initial ping is sent with defaults which switch MNs to SENTINEL_PING_EXPIRED state while they should really be in PRE_ENABLED state. The fix is to split this verification in two parts - this way sentinel version is only checked after at least one ping is received from the masternode itself and not from the cold wallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial ping is sent with defaults which switch MNs to SENTINEL_PING_EXPIRED state while they should really be in PRE_ENABLED state. The fix is to split this verification in two parts - this way sentinel version is only checked after at least one ping is received from the masternode itself and not from the cold wallet.