Implement CQuorum and CQuorumManager #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
force-pushed
the
pr_llmq_quorummgr
branch
from
9f9832d
to
edac100
Compare
UdjinM6
dismissed
their stale review
Requested changes were addressed in one way or another
UdjinM6
reviewed
Jan 17, 2019
|
Hmm, test failure (no log output from unit tests) happened the second time on this branch already. Other times it worked. Not sure if we can ignore this. |
|
Yeah, that's concerning a bit but I don't see how any of recent changes could affect wallet tests, it's probably some older bug/issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.