Optimize LLMQs initialization and (de)serialization of BLS signatures #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases it takes too much time to perform full deserialization of BLS signatures in the message handler thread. Better to just read the buffer and do the actual deserialization when the signature is needed for the first time (which is can be in another thread).
This removes the burden on the message handler thread when many sig batches arrive. The expensive part of deserialization is now performed in the sig shares worker thread. This also removes the need for the specialized deserialization of the sig shares which tried to avoid the malleability check, as CBLSLazySignature does not perform malleability checks at all.
Fuzzbawls
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Aug 9, 2024
22efef0 No matter how fast we process sig shares, always force 100ms between sending (Alexander Block) 1bd0c2f Don't sleep in WorkThreadMain when CPU intensive work was done (Alexander Block) 40a247d Implement caching in CRecoveredSigsDb (Alexander Block) 6c63a77 Use CBLSLazySignature in CBatchedSigShares (Alexander Block) bff6e6e CLLMQUtils::IsQuorumActive() shouldn't require cs_main to be held (UdjinM6) fdba615 Introduce startBlockHeight to make things more explicit (Alexander Block) 7bca9a2 Correctly use SIGN_HEIGHT_OFFSET when checking for out of bound height (Alexander Block) 04b6a67 Reserve 4k of buffer for CSerializedNetMsg buffer (Alexander Block) be1c4a7 Fix cleanup of old recovered sigs (Alexander Block) Pull request description: Backport dash PRs (in the following order): dashpay#2640 dashpay#2672 dashpay#2674 dashpay#2702 dashpay#2705 dashpay#2706 dashpay#2707 NB: Some or them are partial backports since most of our llmq files are already updated to a more recent upstream version. So I basically ended up picking the commits that touch only the files `quorums_signing_shares.*` and `quorums_signing.*` I suggest to review by checking each individual commit against the corresponding upstream one ACKs for top commit: 22efef0 Liquid369: tACK 22efef0 Duddino: ACK 22efef0 Tree-SHA512: 94e5dcdef044524ad4fa4d1fadbe670d839a08ccadc39071ba9300cfc44ce3d19ba24dfef1a6c6745271139d43f43ea47ed5a29e06f0d94e13ff09957f8e0c10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Profiling has shown that the message handler thread is blocked quite a lot by deserialization of BLS signatures when sig share batches arrive. This PR moves the heavy part of the deserialization into
CSigSharesManager::WorkThreadMain, so that the message handler thread can continue working on other messages.