Specify DIP3 enforcement block height/hash for mainnet params #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
approved these changes
Apr 3, 2019
schinzelh
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
ACK - verified via block explorer
https://explorer.dash.org/block/000000000000002d1734087b4c5afc3133e4e1c3e1a89218f62bcd9bb3d17f81
codablock
added a commit
to codablock/dash
that referenced
this pull request
Apr 4, 2019
This is a hackish version of dashpay#2824, meant for 0.13.x only. The reason for this hackish version is that the code has diverged quite a bit and its not worth the effort to backport the hardening code. Even though 0.13.x included a lot of fixes for sporks handling and syncing, I still feel more safe with hardening the spork15 block height. If something goes wrong with spork syncing (e.g. its slower then the first DIP2/3 block arrives), the whole sync process will fail otherwise.
codablock
added a commit
to codablock/dash
that referenced
this pull request
Apr 4, 2019
This is a hackish version of dashpay#2824, meant for 0.13.x only. The reason for this hackish version is that the code has diverged quite a bit and its not worth the effort to backport the hardening code. Even though 0.13.x included a lot of fixes for sporks handling and syncing, I still feel more safe with hardening the spork15 block height. If something goes wrong with spork syncing (e.g. its slower then the first DIP2/3 block arrives), the whole sync process will fail otherwise.
codablock
added a commit
that referenced
this pull request
Apr 4, 2019
This is a hackish version of #2824, meant for 0.13.x only. The reason for this hackish version is that the code has diverged quite a bit and its not worth the effort to backport the hardening code. Even though 0.13.x included a lot of fixes for sporks handling and syncing, I still feel more safe with hardening the spork15 block height. If something goes wrong with spork syncing (e.g. its slower then the first DIP2/3 block arrives), the whole sync process will fail otherwise.
codablock
added a commit
that referenced
this pull request
Apr 4, 2019
This is a hackish version of #2824, meant for 0.13.x only. The reason for this hackish version is that the code has diverged quite a bit and its not worth the effort to backport the hardening code. Even though 0.13.x included a lot of fixes for sporks handling and syncing, I still feel more safe with hardening the spork15 block height. If something goes wrong with spork syncing (e.g. its slower then the first DIP2/3 block arrives), the whole sync process will fail otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.