Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set the nStartTime for v19 deployment Fed 22 and March 31st respectively #5218

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

ogabrielides
ogabrielides previously approved these changes Feb 22, 2023
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ogabrielides
ogabrielides previously approved these changes Feb 22, 2023
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need the timeout to be set too?

@ogabrielides
Copy link
Collaborator

Don't we need the timeout to be set too?

For Mainnet only

src/chainparams.cpp Outdated Show resolved Hide resolved
ogabrielides
ogabrielides previously approved these changes Feb 22, 2023
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rd.. utACK

@thephez
Copy link
Collaborator

thephez commented Feb 22, 2023

3rd.. utACK

So you don't want me to point out the inconsistent whitespace preceding the comments?? 🙂

@ogabrielides
Copy link
Collaborator

3rd.. utACK

So you don't want me to point out the inconsistent whitespace preceding the comments?? 🙂

I'll give you 1 DASH if you don't :)

@PastaPastaPasta
Copy link
Member Author

LOL

src/chainparams.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4th..utACK

@thephez
Copy link
Collaborator

thephez commented Feb 22, 2023

4th..utACK

I'm glad you don't average 1.333 utACKs per changed line of code on every PR 😅 :trollface:

@PastaPastaPasta PastaPastaPasta changed the title chore: set the nStartTime for v19 deployment Fed 22 and April 2 respectively chore: set the nStartTime for v19 deployment Fed 22 and March 31st respectively Feb 22, 2023
@PastaPastaPasta PastaPastaPasta merged commit 4600d6c into dashpay:develop Feb 22, 2023
@PastaPastaPasta PastaPastaPasta deleted the v19-deployment-dates branch February 22, 2023 17:09
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Feb 22, 2023
…spectively (dashpay#5218)

## Issue being fixed or feature implemented

## What was done?

## How Has This Been Tested?

## Breaking Changes

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation

**For repository code-owners and collaborators only**
- [x] I have assigned this pull request to a milestone
@thephez thephez modified the milestones: 20, 19 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants