-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add v20.0.0 release notes, archive v19.3.0 and drop partial ones #5674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still in draft, but here's a partial initial review
@@ -36,49 +36,429 @@ reindex or re-sync the whole chain. | |||
|
|||
# Notable changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these are no longer relevant for v20, right? (updated product brief: https://www.dash.org/blog/dashcore-v20-0-product-brief/)
doc/release-notes.md
Outdated
rewards will change to 20% and 60% respectively upon activation of the change, | ||
previous reallocation periods are ignored. | ||
|
||
## Enhanced hard fork |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer v20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's fully implemented and activated via v20
afaik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantics perhaps. I guess it's implemented, but not going to be used for anything on mainnet in v20? #5642
enabled by the `v20` activation and `SPORK_24_EHF` spork (__TODO__: is this true?) and will be used for | ||
the `mn_rr` hard fork. | ||
|
||
## Asset lock and unlock transactions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer v20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost the same, fully implemented but only "lock" part is activated in v20. Tweaked it a bit.
|
||
- `testmempoolaccept` and `sendrawtransaction` no longer return the P2P `REJECT` | ||
code when a transaction is not accepted to the mempool. They still return the | ||
verbal reject reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what is meant by "verbal reject reason" 🤔 It returns a message but no error code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's a copy-paste from doc/release-notes-17004.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more details
f49ed8c
to
1e3db8d
Compare
squashed all the fixes and rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be a few more. I'm just going 🤪 looking at this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Issue being fixed or feature implemented
NOTE: this PR is for v20.x branch, to be merged as the last one before v20 release.
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: