Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add v20.0.0 release notes, archive v19.3.0 and drop partial ones #5674

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Nov 5, 2023

Issue being fixed or feature implemented

NOTE: this PR is for v20.x branch, to be merged as the last one before v20 release.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20 milestone Nov 5, 2023
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still in draft, but here's a partial initial review

@@ -36,49 +36,429 @@ reindex or re-sync the whole chain.

# Notable changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are no longer relevant for v20, right? (updated product brief: https://www.dash.org/blog/dashcore-v20-0-product-brief/)

doc/release-notes.md Outdated Show resolved Hide resolved
rewards will change to 20% and 60% respectively upon activation of the change,
previous reallocation periods are ignored.

## Enhanced hard fork
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer v20?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fully implemented and activated via v20 afaik

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantics perhaps. I guess it's implemented, but not going to be used for anything on mainnet in v20? #5642

enabled by the `v20` activation and `SPORK_24_EHF` spork (__TODO__: is this true?) and will be used for
the `mn_rr` hard fork.

## Asset lock and unlock transactions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer v20

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost the same, fully implemented but only "lock" part is activated in v20. Tweaked it a bit.

doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved

- `testmempoolaccept` and `sendrawtransaction` no longer return the P2P `REJECT`
code when a transaction is not accepted to the mempool. They still return the
verbal reject reason.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is meant by "verbal reject reason" 🤔 It returns a message but no error code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's a copy-paste from doc/release-notes-17004.md

doc/release-notes.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more details

doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
@UdjinM6 UdjinM6 marked this pull request as ready for review November 13, 2023 16:35
doc/release-notes.md Outdated Show resolved Hide resolved
@UdjinM6
Copy link
Author

UdjinM6 commented Nov 13, 2023

squashed all the fixes and rebased

doc/release-notes.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a few more. I'm just going 🤪 looking at this.

doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
doc/release-notes.md Outdated Show resolved Hide resolved
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@PastaPastaPasta PastaPastaPasta merged commit 3be7979 into dashpay:v20.x Nov 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants