Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: merge bitcoin#20018, #22141, #22221, #22653, #23054, #23398, #23175, #22362, #23769, #23936, #24238, #24331 (auxiliary backports: part 15) #6260

Merged
merged 12 commits into from
Sep 11, 2024
Merged

backport: merge bitcoin#20018, #22141, #22221, #22653, #23054, #23398, #23175, #22362, #23769, #23936, #24238, #24331 (auxiliary backports: part 15) #6260

merged 12 commits into from
Sep 11, 2024

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Sep 8, 2024 •
edited
Loading

Additional Information

  • When backporting bitcoin#23054, sigOpCount and nSigOpCountWithAncestors were switched from unsigned int to int64_t. This change was done to prevent integer narrowing when accepting the int64_t taken from the constructor.

    This isn't a problem upstream as the same changes were as part of bitcoin#8149, which was omitted but the type changes remain valid as sigop count cannot be a negative number.

Breaking Changes

None observed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg
merge bitcoin#20018: ProcessAddrFetch(-seednode) is unnecessary if -c…
c0e6792 
…onnect is specified
@kwvg
merge bitcoin#22141: net processing: Remove hash and fValidatedHeader…
68657ef 
…s from QueuedBlock
@kwvg
merge bitcoin#22221: Pass block reference instead of pointer to PeerM…
e24324d 
…anagerImpl::BlockRequested
@kwvg
merge bitcoin#22653: Rename JoinErrors and re-use it
d158063
@kwvg
merge bitcoin#23054: Use C++11 member initializer in CTxMemPoolEntry
22e59fb
@kwvg
merge bitcoin#23398: add return message to savemempool RPC
d57c96e
@kwvg
merge bitcoin#23175: Add CJDNS network to -addrinfo and -netinfo
109c963
@kwvg
merge bitcoin#22362: Drop only invalid entries when reading banlist.json
5b66688
@kwvg
merge bitcoin#23769: Disallow copies of CChain
b4bfacf
@kwvg
merge bitcoin#23936: Add and use EnsureArgsman helper
e039aec
@kwvg
merge bitcoin#24238: use arc4random on OpenBSD
15e794b
@kwvg
merge bitcoin#24331: Revert back MoveFileExW call for MinGW-w64
6c7335e
@kwvg kwvg marked this pull request as ready for review September 10, 2024 12:38
PastaPastaPasta
PastaPastaPasta approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6c7335e

UdjinM6
UdjinM6 approved these changes Sep 11, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6c7335e

@PastaPastaPasta PastaPastaPasta merged commit 6019a87 into dashpay:develop Sep 11, 2024
35 checks passed
@UdjinM6 UdjinM6 added this to the 21.2 milestone Sep 11, 2024
@thephez thephez added the RPC Some notable changes to RPC params/behaviour/descriptions label Sep 18, 2024
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
22
Development

Successfully merging this pull request may close these issues.
4 participants
@kwvg @UdjinM6 @PastaPastaPasta @thephez