Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align branches with upstream #68

Merged
merged 13 commits into from
Dec 11, 2014
Merged

Conversation

vertoe
Copy link

@vertoe vertoe commented Dec 11, 2014

Aligns my working branch with the bitcoin 0.9 and darkcoin 0.11 branches.

Changes upstream:

  • disable sslv3 in favour for tls for rpc client and server 0a94661
  • limit number of new addressses to accumulate bb424e4

Bug fixes for Darkcoin:

Misc for Darkcoin:

  • Updates strings (Bitcoin -> Darkcoin)

vertoe and others added 13 commits December 6, 2014 16:42
TLS is subject to downgrade attacks when SSLv3 is available, and
 SSLv3 has vulnerabilities.

The popular solution is to disable SSLv3. On the web this breaks
 some tiny number of very old clients. While Bitcoin RPC shouldn't
 be exposed to the open Internet, it also shouldn't be exposed to
 really old SSL implementations, so it shouldn't be a major issue
 for us to disable SSLv3.

There is more information on the downgrade attacks and disabling
 SSLv3 at https://disablessl3.com/ .

Rebased-From: 683dc40
darkcoinproject added a commit that referenced this pull request Dec 11, 2014
Align branches with upstream
@darkcoinproject darkcoinproject merged commit 7a0df8c into dashpay:v0.11.0.x Dec 11, 2014
@darkcoinproject
Copy link

Perfect, thanks

barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jul 17, 2019
Changed the update complete text to get people to start from cold wallet.
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jul 17, 2019
* CSS margin for pages, sendcoins relocated structure, code cleaning

* CSS sendcoins dialog form modified and bug fixed with purging overview

CSS sendcoins dialog form modified
removing a label from overview which is now in private

* Bug fixed

a not found font was being referenced

* Removing unused code

* Loading arrows and Fix for earlier versions of QT

* CSS sendcoins dialog and entry modified

* CSS sendcoinsdialog, sendcoinsentry, receivecoins and QDialog styles

backgrounds dark color and transparencies

* Styles changed for overview and statubar

Unit display color on status bar
Overview page: layout and USD labels

* Private view layout and some style

* Header section for socket message ui, testing

Still testing ui
overview css class implemented

* Info icon on Private and Overview

* Combo box style

* Styles of combo box and gitignore updated

Combo box not invading the tables, and disable mode

* Header bar for socket message and testing ui for button

* CSS header profile picture, still testing

* SpinBox style and Table style

* CSS recent transactions and dynamic text colors depending on theme

If pac theme is set the white color will be the default for text. other wise it will be a dark text

* Transaction bar at top of the tables

* Personalized fonts and CSS

Personalized fonts added and text colors for tables and lists

* Private (background, button style), Send coins page (alignment).

* CSS receivecoinsdialog positions and styles modified

also tableview text color is now set as white

* Send Coins page layout 90%

* New customized fonts

VolteRounded font for PAC

* Bug fixed: Mistake writing qrc fixed

* Send coins choose transaction fee moved and added a scroll area

* Typography implemented on the code

Volte Rounded

* Default typography changed and new header bar

Header bar for messages and profile picture implemented
CSS, images, and elements ready to be programmed
Application typography Volte Rounded is now the default for the wallet

* Layout alignment

* UI modifications

Specific details

* Receive Page background

* Layout for bigger screens, checkbox added

* Toolbar and headerbar Size modifed, CSS

CSS of QToolButtons:
 - background when selected has changed
 - height and width
QToolBar width
Main Pac Icon modified and centered
HeaderBar spacer added and select image changed

* Proposal table layouts, private button and layout

* custom ScrollBar implemented

* Spinbox arrows layout, controls colors.

* Global Button style fixed

Border now transparent

* Private colors and shadow, send margin

* Receive coins 

link buttons and layout modifed
spaces and margins

* Background of dialog when closing app

* Private_Overview functionality fix

* Adding commas to make more easy to read large numbers

* Re sorting buttons of tool bar menu and fixing disabled push button

* Progress, unfinished components

masternodes tab navigation 
label of masternodes 
addressbookpage table columns to be tested

* remove border of Disabled link buttons

* Private (info button, and sizes), SendPage (balance working)

* Commas instead of spaces on bitcoinunits fixed bug

there was a bug in where the negative quantities where not being converted properly

* AddressBookPage and EditAddressDialog styles

table styles modified
inputs to fit with UI design

* Receive layout and tables headers color

* Masternodes and other css style

* Table separations and overview layout test

* No longer posible to set old theme "light" with GUI

* Overview icon spacing, masternode lineedit style

* new typography implemented gotham and Volte rounded

Volte rounded: light, medium, semibold and bold
gotham: medium and bold.

* merge

* style fixed with Gotham Medium typography

family font was wrong

* clocks and eyes icons

* Overview info button

* Checkbox and Radio button disable icon

* Backend for the balance on the receive page

* fix toolbar button height

* Receive coins re-formulated

* Image Picker beta 1

still testing

* Receive page front end balance, and responsive layout

* Combobox fix, overlay style, possible fix on receive send page

* Merging headers on bitcoingui

* Image picker now storage the image inside Paccoincore folder

depending in each plataform the program will copy and paste the image selected, overwrite it if it exist and then each time the wallet loads it will choose the image from that path. 

The image will be copied where the .conf is located without file extention.

Only allowed .xmp and .jpg images since .png files can't be loaded (QT bug apparently)

* Bug fixed: img picker when cancelling button clicked

if you were about to select an image from the file picker and decided to not select anything. When clicking cancel button the button would set the image as black. Now it keeps the last image.

* Fix to the Private and overview displays

* Amount on receive and send rearrange

* New background, fix to info doubleclicked

* Bug Fixed: AccentButton lost shape with small screens

Sending coins page

* Icons replaced

accurate style and color correction

* CSS Code optimization and combobox color fixed

removing innecesary code and code that was being repeated 

CSS:
- table header height fixed
- arrow for sorting customized

* Socket news connected only the half

* Socket news working

* Replaced icon editpaste

* css header table

* Getting the PAC USD value

* QRC header file fix

* Overview message info and PAC value send to the wallet frame

* PAC value send to walletview

* UI Fixes for small screens (send and receive page)

* Unused code

* PAC value using QSettings

* QRCode implementation and restyle

* Code mistake fixed

forgot to delete it

* QRCode on receivecoins size fixed

* Show the USD value of your PACs

* Overview message updated

* USD PAC conversion validated

* UI receive page minor fix for small screens

* Wallet without sockets

* QRC fix

* make include FIX

* Bitcoin amount field FIX

Not working with commas.

* update-deps

* add patches

* PACtoUSD removal

* BugFixed with BitcoinAmountField comma

the spinner was not detecting the amount with the comma. It was removed from this control

* Amperson removed from ui

* RCC was not finding the icons and assets

It should work now

* completion

* Add dmg background

* macdeploy missing files

* Change tar.gz name

* update-deps

* add patches

* completion

* Add dmg background

* macdeploy missing files

* Change tar.gz name

* Migrate macdeploy to python3

* Change tar.gz name on gitian descriptors.

* Auto stash before merge of "socket_semoval" and "origin/socket_semoval"

* Change windows setup filename

* asset correction

removed unused image.
Replaced format jpg to png on background

* UI BugFixed 

Style now is default.
Removed unused code. 
Button icons removed from linux and windows.

* jpg to png background fix

* profile img removed from make.qt.include

* Auto stash before merge of "socket_semoval" and "origin/socket_semoval"

* asset correction

removed unused image.
Replaced format jpg to png on background

* UI BugFixed 

Style now is default.
Removed unused code. 
Button icons removed from linux and windows.

* jpg to png background fix

* profile img removed from make.qt.include

* News message deleted

* Icons on Windows deleted

* Scrollbar horizontal ui fixed

* BugFixed

a comma unwanted

* restoring cross platform functionality of icons on buttons

was already disabled

* Overview info updated and dialog URI background changed

* MyMasternodes table style fix

* GCC-7 and glibc-2.27 compat code

* Add stdin, stdout, stderr to ignored export list

* Backport move to Ubuntu Bionic and GCC7 in Gitian builds (dashpay#2225)

* Add stdin, stdout, stderr to ignored export list

* Merge bitcoin#13171: Change gitian-descriptors to use bionic instead

c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee)

Pull request description:

  I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol:
  ```
  test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0
  test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27
  qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0
  qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27
  ```
  I think this should be fixed in `./configure --enable-glibc-back-compat`

  Should not be merged before bitcoin#13177 devrandom/gitian-builder#178

  Close bitcoin#12511

Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f

* Use IN6ADDR_ANY_INIT instead of in6addr_any

This is the same fix as bitcoin@fc6a9f2
Couldn't backport the original commit as we are missing some refactorings.

* BugFixed: Table borders on windows and linux now transparent

border:none;

* Private page tool tip fix

* BugFixed UI send and receive coins

When coins control dialog open.  right colum was getting small.

Sendcoins page: coins control re located.

Table of history requested coins was too small in height.

QRCode address otput implementation (pending to finish)

* Sign/Verify message, base for news with an API

* CSS Qtooltip custom style

* CSS QProgressBar and QuickButton class

rounded corners.

* Receive coins Address 

hidden for default, visible after requesting payment.
Copy to clipboard button.

* BugFixed: Toolbar can't be hide now

It was able to be hide without being able to show it again

* proposal table> Fixing width of the tables 

width of first column of tables was too small.

* BugFixed: href color changed to easy read

* Animated QRCode and Address UX

in order to make the user able to notice when is changing.

Tableview row will be focused too

* Syncing with master branch (#1)

* Delayed block penalization and new reward percentages (dashpay#66)

* Delayed block penalization (dashpay#62)

- Delayed block penalization
- Reset regtest
- Change protocol version
- Update blockdelay RPC test.
- Fix min chain work on regtest chain params.
- Add chain penalization field to getchaintips method.
- Fix log formating

* New reward percentages 70215 (dashpay#63)

Changing the reward percentages, miners now get 15% and masternodes get 65%.

* Change activation block height for new rewards

* Bump min protocol and new checkpoint (dashpay#65)

- Min protocol version is now 70215
- Bumped the version on the masternode update scripts.
- Added a checkpoint, block `#216000`.

* Update README.md, adding the PacNodesUpdater instructions (dashpay#67)

* Update README.md

* Added PacNodesUpdater script

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update PAC_update.sh (dashpay#68)

Changed the update complete text to get people to start from cold wallet.

* Update pac-update.sh (dashpay#69)

* CSS UI BugFixed

Buttons width larger to fit content text, LineEdit for pac address larger for easy to read (on requesting coins).

* UI send and receive coins

spacer for the hidden fees features so it fits the scrollarea.

Buttons size and margins

LineEdit class changed

* Fixes and News/pac-usd

-Update news
-Update pac-usd value (only overview)
-info on overview updated of where we get the pac-usd value
-Copy news button
-Unused code deleted

* UI fixed

* Update send and receive labels for USD

* Options dialog label warning fixed size

* html <a> href style from blue to yellow

* News pointing to the right API

* Tooltips for copy and refresh news

* Background and selection bar colors

* General backgrounds and text inputs colors changed

To have a better contrast on the elements and text.

* CSS send coins, progressbar, check and radiobutton merging

branches v1.2 to 1.3
radiobutton, checkbutton with spaces 
layouts modified

* Top bar color darker

* Qslider customized and sendcoinsdialog

* Fix typo

* "Pay to" recipient separator

* new mined icon

* Tables have more colors to make it prettier

* Qslider css,  recent transactions font size, pac to usd width

* Optimizing CSS, layouts fixed

removing btnCopyNews and btnRefreshNews styles, using QuickButton instead.

Replaced QPushButton to QToolButton

* Unnecessary code

* Masternode table white text

* Master nodes Table not enabled text to red

* Pixel Size font 

trying to fix windows dpi font issues

* CSS and layout fixing

QRCode and other forms layout now fixed sizes in order to fit properly

* Button to copy the conversion of USD-PAC

* AddressBookPage table fix text color

* Private page advance mode ui fixes

Red color to bright, buttons not align and progress bar not center.

* Masternodes Page tabs color and size change

* Coin control dialog UI fixes

Style of the table, white borders, and cut labels.

* Translations fix German and Spanish

* SendCoins CoinControl scrollbar and better displaying

* Possible fix for windows

On preferences the tabs go out on the left

* User can now select typography 

cuz it was hurting users eyes

* Custom Font Typo 

Now the user can select any typography installed on the system. In addition to the default ones for the UI

* News feed can show a longer text

* Radio button color change

* Some documentation for the code

* Code reorganization and comments

* Merge, QFont, QRCode

QRcode will resize on small and big screens

* QRCode BugFixed

it was stretching a lot. Now it will respect the layout

* QRCode resized fixed

When the button was clicked it was not setting the window. height

* Light theme start of typo and backgrounds.

* CSS and UI Bug fixed

- Background Image now resize keeping aspect ratio.
- Profile Image button now is capable of restoring original pac logo/changing the current image. 
- purging code (removing std::cout debbugers)
- BugFixed: sendcoinsentry address typography was different, now it takes the selected font for the wallet.
- BugFixed: receive coins page, the form was being cropped on small screens, changed the layouts and min height.
-

* Test

* Private Page message corrupting the view on small devices.

* Modal Overlay UI modification

* margin on private page label

* profile img button

bug fixed it was starting blank (attempting)

* Tab bar and color palette changed

* Trying to fix Font problems

default pac font to be selected automatically

* Font size now medium

in order to make it more readable

* Fix of my failed merge

* trying to fix font default

* Custom Font Bug Fixed

Now the font will be medium. Code optimized.

* Using alias and CSS Black and grey

* Bug Fixed> The checkboxes on receive coins page were squeezing

* Fixing contrast of ui elements 

including the toolbar selected button and the inputs

* SendCoins page "Fee" fix decimals

* Micro sign on Overview fix

* Micro sign on Private Page fix

* bitcoinamount field changed

in order to be fixed on height

* separator implemented

On send coins page -> the text inputs were too close. A separator should fix this issue presented only on windows.

* ui fixed

* Typography fixing

* Fig compilation error

due to qt version this property can not be compiled

* New icon colors, images added on css now and table colors change

* UI enhancement

* CSS Light theme changes

* Revert "Merge branch 'new-ui_v1.5white' into new-ui_v1.4"

This reverts commit 2e2c5de.
FornaxA pushed a commit to ioncoincore/ion that referenced this pull request Jul 6, 2020
…locks_DoS_spam_filter

[bug][maintenance][docs] Invalid blocks storage and blocks do s spam filter
FornaxA added a commit to ioncoincore/ion that referenced this pull request Jul 6, 2020
Regtest fix

Approved-by: Cevap
kwvg added a commit to kwvg/dash that referenced this pull request Mar 16, 2023
9329803969 wip: fix FromBytesUnchecked (dashpay#68)
767713de3d feat: js bindings in camel case (dashpay#66)
06df92693a chore(release): bump version (dashpay#64)
73593feefd fix: the JS bundle script and bindings (dashpay#47)
38a8f768c6 Merge pull request dashpay#61 from kittywhiskers/compat_support
d9b375145e ci: ensure that CMakeFiles are compatible with LTS-bundled cmake
5ba1b520cc build: restore CMake 3.14.0 compatibility
d1c1b66e5f backport: merge bls-signatures#332 (Python 3.11)

git-subtree-dir: src/dashbls
git-subtree-split: 9329803969fd325dc0d5c9029ab15669d658ed5d
knst pushed a commit to knst/dash that referenced this pull request Jul 11, 2024
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy)
303cfc6 allow darkmode on macos build (Sylvain Goumy)
78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab)

Pull request description:

  Allow icons to be colorized on macOS to support native Dark mode color scheme.

  Rendering on macOS Big Sur before PR:
  ![macos-darkmode-before-pr](https://user-images.githubusercontent.com/5577626/102502739-43f3af80-407f-11eb-9263-5bbc27b371c2.png)

  Rendering on macOS Big Sur after PR:
  ![macos-darkmode-after-pr](https://user-images.githubusercontent.com/5577626/102502678-350cfd00-407f-11eb-8b98-e271f2688c36.png)

  Light mode stay visually unchanged.

  <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del>
  <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del>
  Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build.

  Linked issues: dashpay#68 dashpay#136

ACKs for top commit:
  hebasto:
    re-ACK dc4551c
  jarolrod:
    ACK dc4551c

Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
knst pushed a commit to knst/dash that referenced this pull request Jul 12, 2024
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy)
303cfc6 allow darkmode on macos build (Sylvain Goumy)
78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab)

Pull request description:

  Allow icons to be colorized on macOS to support native Dark mode color scheme.

  Rendering on macOS Big Sur before PR:
  ![macos-darkmode-before-pr](https://user-images.githubusercontent.com/5577626/102502739-43f3af80-407f-11eb-9263-5bbc27b371c2.png)

  Rendering on macOS Big Sur after PR:
  ![macos-darkmode-after-pr](https://user-images.githubusercontent.com/5577626/102502678-350cfd00-407f-11eb-8b98-e271f2688c36.png)

  Light mode stay visually unchanged.

  <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del>
  <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del>
  Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build.

  Linked issues: dashpay#68 dashpay#136

ACKs for top commit:
  hebasto:
    re-ACK dc4551c
  jarolrod:
    ACK dc4551c

Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
knst pushed a commit to knst/dash that referenced this pull request Jul 12, 2024
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy)
303cfc6 allow darkmode on macos build (Sylvain Goumy)
78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab)

Pull request description:

  Allow icons to be colorized on macOS to support native Dark mode color scheme.

  Rendering on macOS Big Sur before PR:
  ![macos-darkmode-before-pr](https://user-images.githubusercontent.com/5577626/102502739-43f3af80-407f-11eb-9263-5bbc27b371c2.png)

  Rendering on macOS Big Sur after PR:
  ![macos-darkmode-after-pr](https://user-images.githubusercontent.com/5577626/102502678-350cfd00-407f-11eb-8b98-e271f2688c36.png)

  Light mode stay visually unchanged.

  <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del>
  <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del>
  Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build.

  Linked issues: dashpay#68 dashpay#136

ACKs for top commit:
  hebasto:
    re-ACK dc4551c
  jarolrod:
    ACK dc4551c

Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
knst pushed a commit to knst/dash that referenced this pull request Jul 15, 2024
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy)
303cfc6 allow darkmode on macos build (Sylvain Goumy)
78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab)

Pull request description:

  Allow icons to be colorized on macOS to support native Dark mode color scheme.

  Rendering on macOS Big Sur before PR:
  ![macos-darkmode-before-pr](https://user-images.githubusercontent.com/5577626/102502739-43f3af80-407f-11eb-9263-5bbc27b371c2.png)

  Rendering on macOS Big Sur after PR:
  ![macos-darkmode-after-pr](https://user-images.githubusercontent.com/5577626/102502678-350cfd00-407f-11eb-8b98-e271f2688c36.png)

  Light mode stay visually unchanged.

  <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del>
  <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del>
  Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build.

  Linked issues: dashpay#68 dashpay#136

ACKs for top commit:
  hebasto:
    re-ACK dc4551c
  jarolrod:
    ACK dc4551c

Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
knst pushed a commit to knst/dash that referenced this pull request Jul 16, 2024
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy)
303cfc6 allow darkmode on macos build (Sylvain Goumy)
78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab)

Pull request description:

  Allow icons to be colorized on macOS to support native Dark mode color scheme.

  Rendering on macOS Big Sur before PR:
  ![macos-darkmode-before-pr](https://user-images.githubusercontent.com/5577626/102502739-43f3af80-407f-11eb-9263-5bbc27b371c2.png)

  Rendering on macOS Big Sur after PR:
  ![macos-darkmode-after-pr](https://user-images.githubusercontent.com/5577626/102502678-350cfd00-407f-11eb-8b98-e271f2688c36.png)

  Light mode stay visually unchanged.

  <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del>
  <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del>
  Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build.

  Linked issues: dashpay#68 dashpay#136

ACKs for top commit:
  hebasto:
    re-ACK dc4551c
  jarolrod:
    ACK dc4551c

Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
knst pushed a commit to knst/dash that referenced this pull request Jul 23, 2024
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy)
303cfc6 allow darkmode on macos build (Sylvain Goumy)
78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab)

Pull request description:

  Allow icons to be colorized on macOS to support native Dark mode color scheme.

  Rendering on macOS Big Sur before PR:
  ![macos-darkmode-before-pr](https://user-images.githubusercontent.com/5577626/102502739-43f3af80-407f-11eb-9263-5bbc27b371c2.png)

  Rendering on macOS Big Sur after PR:
  ![macos-darkmode-after-pr](https://user-images.githubusercontent.com/5577626/102502678-350cfd00-407f-11eb-8b98-e271f2688c36.png)

  Light mode stay visually unchanged.

  <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del>
  <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del>
  Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build.

  Linked issues: dashpay#68 dashpay#136

ACKs for top commit:
  hebasto:
    re-ACK dc4551c
  jarolrod:
    ACK dc4551c

Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants