Add masternode tab in qt wallet #776
Conversation
| nDurationTime /= 60; | ||
| int hours = nDurationTime % 24; | ||
| int days = nDurationTime / 24; | ||
| if((hours == 0)&&(days == 0)) |
There was a problem hiding this comment.
Nit: Would be nice to have some extra whitespace around the &&.
Might also consider removing inner parenthesis as similar conditions in this project don't seem to use them (eg: addresstablemodel.cpp).
There was a problem hiding this comment.
agree, rewritten this part, see 3764e68#diff-8e9b29a6133dd7bf43643c37c5c4689aR94
|
concept ACK, i love it |
|
Thanks @UdjinM6! Assuming the list of "All Masternodes" will be very long, should we make "My Masternodes" the default (and move to the left position)? The user would need to take action (click) on "All Masternodes" in order to initiate display of the long list which seems like better UX. |
|
I agree, "My Masternodes" should be default tab. |
|
Nit addressed 3764e68#diff-8e9b29a6133dd7bf43643c37c5c4689aR94, tabs swapped and I also removed few debug |
|
Love it as well 👍 Good thing is, I wanted to implement something like this myself and fortunately didn't yet start. Time saved to break other things 😎 |
|
Looking forward for a new icon for Masternodes tab from @snogcel 😄 (will also require slight code changes) |
|
Builds and runs as expected on both operating systems (and Windows also 😈 , tested with 8.1 and 10). Protocol column needs some more room, and making the column width adjustable would be nice (but I can live without that): |
- set initial columns size - use resizable columns - use theme-dependent masternodes icon (placeholder, should be replaced) - removed unused event binding - capitalization, more verbose ui element names
|
@crowning- : agree, pushed new fixes in additional commit (will squash all commits into one and rebase if needed later). |
…be set to true at first run for those who have masternodes in their masternode.conf and false for others.
|
Was not quite happy with no way to control Masternodes tab appearance so added a semi-automatic gui option.
PS. someone, pls, double check my English for tooltip here and for a "Note" in "My Masternodes" sub-tab |
|
Icon updated, thanks @salmion! |
|
Shouldn't conceptually the "Show Masternodes Tab" checkbox be right below the "Enable coin control features" checkbox? |
|
@crowning- probably... wasn't sure about where to place it but yeah, I guess that will be a better place. moved :) |
|
found and fixed a dumb bug, see 86bca13 |
|
@UdjinM6 if we'd ever meet in real life having a beer and I would tell you just HOW often I have connected wrongly attributed signals in Qt you'd have a LOT of beers when I'm finished...:stuck_out_tongue_winking_eye: |
|
This is greeeat!!! 👍 👍 👍 |
|
Merged! |
|
Bummer, i wanted this to be squashed first :) N/m |
What's inside:
MASTERNODELIST_UPDATE_SECONDS(5) seconds)MY_MASTERNODELIST_UPDATE_SECONDS(60) seconds (could be cpu-heavy for large lists)Tab will be active only if there is at least one legit line in masternode.conf, normal users should see no difference/performance impact.