Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Dash Core 20 #237

Merged
merged 58 commits into from
Dec 8, 2023
Merged

feat: support Dash Core 20 #237

merged 58 commits into from
Dec 8, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
fix: toJson method
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
…ltRiskAnalysis

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
* Signatures and Keys are not a child objects

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
* chore: deprecate default constructor

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
…essfully to each peer

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
…te managers

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
* set current protocol to 70230

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
* set v20 activation height in TestNet3Params

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
* This will help with masternode and quorum list sync when receiving transactions

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
… objects (#231)

* refactor: create DualBlockChain class to handle header and regular chain objects

* tests: add DualBlockChainTest

* fix: pass keycrypter to AnyBasicKeyChain to fix wallet decryption bug

* update AuthenticationKeyChainGroupTest

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
* remove unused field
* add another check

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
…(rc.2)

Feat: core 20 upgrade testnet (Core v20.0.0-RC.2)
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
…for mnlistdiff

Signed-off-by: HashEngineering <hashengineeringsolutions@gmail.com>
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 276 lines in your changes are missing coverage. Please review.

Comparison is base (7773c1f) 47.11% compared to head (3da9f7a) 48.06%.

Files Patch % Lines
...va/org/bitcoinj/evolution/QuorumRotationState.java 65.33% 38 Missing and 14 partials ⚠️
...va/org/bitcoinj/evolution/AbstractQuorumState.java 39.65% 34 Missing and 1 partial ⚠️
...re/src/main/java/org/bitcoinj/core/BlockQueue.java 54.00% 22 Missing and 1 partial ⚠️
...rc/main/java/org/bitcoinj/core/DualBlockChain.java 56.75% 10 Missing and 6 partials ⚠️
...n/java/org/bitcoinj/quorums/ChainLocksHandler.java 72.00% 9 Missing and 5 partials ⚠️
.../main/java/org/bitcoinj/evolution/QuorumState.java 57.14% 7 Missing and 5 partials ⚠️
...c/main/java/org/bitcoin/paymentchannel/Protos.java 8.33% 11 Missing ⚠️
...ava/org/bitcoinj/evolution/AssetUnlockPayload.java 75.00% 11 Missing ⚠️
core/src/main/java/org/bitcoinj/wallet/Protos.java 70.27% 11 Missing ⚠️
...inj/evolution/SimplifiedMasternodeListManager.java 58.33% 9 Missing and 1 partial ⚠️
... and 23 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #237      +/-   ##
============================================
+ Coverage     47.11%   48.06%   +0.94%     
- Complexity     6472     6674     +202     
============================================
  Files           408      409       +1     
  Lines         45879    46110     +231     
  Branches       6481     6502      +21     
============================================
+ Hits          21618    22163     +545     
+ Misses        21891    21547     -344     
- Partials       2370     2400      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HashEngineering HashEngineering merged commit 0ce9035 into master Dec 8, 2023
9 checks passed
@HashEngineering HashEngineering deleted the feature-core-20 branch January 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant