chore: update to 2.0.0-rc.2 #2565
Conversation
WalkthroughThis change updates the version numbers of multiple packages across the repository from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dashmate
participant ConfigFile
User->>Dashmate: Run config migration (to 2.0.0-rc.2)
Dashmate->>ConfigFile: Iterate configs
Dashmate->>ConfigFile: Delete core.miner.mediantime
Dashmate->>ConfigFile: Update platform.drive.abci image
Dashmate->>ConfigFile: Update platform.dapi.api image
Dashmate-->>User: Return migrated config
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
packages/keyword-search-contract/Cargo.toml (1)
1-14: 💡 Verification agent🧩 Analysis chain
Verify there are no lingering
2.0.0-rc.1references
Run a quick search to ensure all Cargo.toml files have been updated to the new release candidate to avoid version mismatches.
🏁 Script executed:
#!/bin/bash # Ensure no remaining rc.1 references in the repository rg -n "2\.0\.0-rc\.1"Length of output: 126
Update lingering
2.0.0-rc.1referenceA search shows one remaining occurrence of the old release candidate in your migrations factory. Please update it to match the new
2.0.0-rc.2version:• File: packages/dashmate/configs/getConfigFileMigrationsFactory.js
Line: 1079- '2.0.0-rc.1': (configFile) => { + '2.0.0-rc.2': (configFile) => {
🧹 Nitpick comments (1)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1089-1098: New migration added for version 2.0.0-rc.2.The migration is correctly implemented and mirrors the previous
2.0.0-rc.1migration, maintaining consistency in how configuration updates are handled across release candidates.Consider using property assignment to
undefinedinstead of thedeleteoperator for a slight performance improvement:- delete options.core.miner.mediantime; + options.core.miner.mediantime = undefined;🧰 Tools
🪛 Biome (1.9.4)
[error] 1092-1092: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (45)
package.json(1 hunks)packages/bench-suite/package.json(1 hunks)packages/check-features/Cargo.toml(1 hunks)packages/dapi-grpc/Cargo.toml(1 hunks)packages/dapi-grpc/package.json(1 hunks)packages/dapi/package.json(1 hunks)packages/dashmate/configs/getConfigFileMigrationsFactory.js(1 hunks)packages/dashmate/package.json(1 hunks)packages/dashpay-contract/Cargo.toml(1 hunks)packages/dashpay-contract/package.json(1 hunks)packages/data-contracts/Cargo.toml(1 hunks)packages/dpns-contract/Cargo.toml(1 hunks)packages/dpns-contract/package.json(1 hunks)packages/feature-flags-contract/Cargo.toml(1 hunks)packages/feature-flags-contract/package.json(1 hunks)packages/js-dapi-client/package.json(1 hunks)packages/js-grpc-common/package.json(1 hunks)packages/keyword-search-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/package.json(1 hunks)packages/platform-test-suite/package.json(1 hunks)packages/rs-dapi-client/Cargo.toml(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml(1 hunks)packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml(1 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value-convertible/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)packages/rs-platform-versioning/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)packages/token-history-contract/Cargo.toml(1 hunks)packages/token-history-contract/package.json(1 hunks)packages/wallet-utils-contract/Cargo.toml(1 hunks)packages/wallet-utils-contract/package.json(1 hunks)packages/wasm-dpp/Cargo.toml(1 hunks)packages/wasm-dpp/package.json(1 hunks)packages/withdrawals-contract/Cargo.toml(1 hunks)packages/withdrawals-contract/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
🪛 Biome (1.9.4)
packages/dashmate/configs/getConfigFileMigrationsFactory.js
[error] 1092-1092: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Unused dependencies
- GitHub Check: Rust packages (dashpay-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (wallet-utils-contract) / Tests
- GitHub Check: Rust packages (wallet-utils-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (42)
packages/rs-dapi-client/Cargo.toml (1)
3-3: Approve version bump to 2.0.0-rc.2
The crate’s version has been correctly updated from2.0.0-rc.1to2.0.0-rc.2.packages/rs-platform-versioning/Cargo.toml (1)
5-5: Bump crate version to 2.0.0-rc.2The version has been correctly updated from
2.0.0-rc.1to2.0.0-rc.2to align with the coordinated release candidate bump. No further changes are needed in this manifest.packages/data-contracts/Cargo.toml (1)
4-4: Confirm version bump to 2.0.0-rc.2
The crate version has been correctly updated to"2.0.0-rc.2", matching the coordinated bump across the repository.packages/rs-sdk/Cargo.toml (1)
3-3: Crate version correctly bumped to 2.0.0-rc.2
The version update aligns with the repository-wide release. Please ensure the changelog and release notes capture this new version, and verify that any downstream or dependent crates (including JS packages in package.json or other Cargo.toml manifests) have been updated in sync.packages/keyword-search-contract/Cargo.toml (1)
4-4: Version bump to 2.0.0-rc.2 is correct
This update aligns with the coordinated release across all packages.packages/rs-platform-serialization-derive/Cargo.toml (1)
5-5:✅ Verification successful
Confirm version bump consistency. The crate version has been updated to
2.0.0-rc.2, matching the coordinated release candidate update. Run the following to ensure no2.0.0-rc.1references remain across Cargo manifests:
🏁 Script executed:
#!/bin/bash # Verify no leftover rc.1 references in all TOML files rg '"2\.0\.0-rc\.1"' -n --glob '*.toml'Length of output: 41
Version bump to
2.0.0-rc.2confirmed across all Cargo.toml files
Search for leftover"2.0.0-rc.1"references in all*.tomlfiles returned no matches, confirming consistency.packages/rs-platform-version/Cargo.toml (1)
5-5:✅ Verification successful
Bump crate version to 2.0.0-rc.2
The version update aligns with the PR objective to move from2.0.0-rc.1→2.0.0-rc.2.Please verify there are no lingering
2.0.0-rc.1references across the repo:
🏁 Script executed:
#!/bin/bash # Search for stale rc.1 version references rg "2\.0\.0-rc\.1"Length of output: 118
Bump crate version to 2.0.0-rc.2
I ran a search for2.0.0-rc.1and found a single hit in the config‐migration map:• packages/dashmate/configs/getConfigFileMigrationsFactory.js
•'2.0.0-rc.1': (configFile) => { … }This entry is intentional—it ensures users upgrading from rc.1 still get their configs migrated. There are no other lingering references to rc.1, so no further changes are needed.
packages/dapi/package.json (1)
4-4:❌ Incorrect review comment
Bump package version to 2.0.0-rc.2
The version field has been correctly updated from2.0.0-rc.1to2.0.0-rc.2. No other metadata or dependencies were altered.To ensure consistency across the repository, run:
🏁 Script executed:
#!/usr/bin/env bash # Verify no residual rc.1 references remain in the codebase rg -n "2\\.0\\.0-rc\\.1"Length of output: 126
🏁 Script executed:
#!/usr/bin/env bash # Show migration mapping around the rc.1 entry for context sed -n '1070,1100p' packages/dashmate/configs/getConfigFileMigrationsFactory.jsLength of output: 1167
Bump package version to 2.0.0-rc.2
The version inpackages/dapi/package.jsonhas been correctly updated from2.0.0-rc.1to2.0.0-rc.2. No other metadata or dependencies were altered.Note: The reference to
2.0.0-rc.1inpackages/dashmate/configs/getConfigFileMigrationsFactory.jsis part of the migration map (to support upgrading from rc.1) and should remain. No further changes are required.Likely an incorrect or invalid review comment.
packages/wasm-dpp/package.json (1)
3-3: Confirm version bump to 2.0.0-rc.2
Theversionfield matches the coordinated RC update. Dependencies and scripts remain unchanged.packages/rs-dpp/Cargo.toml (1)
3-3: Update crate version to 2.0.0-rc.2
The Cargo manifest’s[package]version has been bumped appropriately. No additional changes are required.packages/dpns-contract/Cargo.toml (1)
4-4: Bump dpns-contract version to 2.0.0-rc.2
Thedpns-contractcrate version is now aligned with the latest RC. Dependencies remain untouched.packages/feature-flags-contract/Cargo.toml (1)
4-4: Upgrade feature-flags-contract version to 2.0.0-rc.2
Version bump is consistent with other contract crates. No other metadata changed.packages/rs-drive/Cargo.toml (1)
4-4: Consistent version bump to 2.0.0-rc.2
The crate’sversionfield has been correctly updated from2.0.0-rc.1to2.0.0-rc.2, aligning with the PR objectives. No unintended changes to dependencies or metadata were introduced.packages/token-history-contract/package.json (1)
3-3: Consistent version bump to 2.0.0-rc.2
The NPM package version has been updated as expected, matching the coordinated release candidate version across all JS and Rust packages. No other modifications detected.packages/masternode-reward-shares-contract/Cargo.toml (1)
4-4: Consistent version bump to 2.0.0-rc.2
The crate’sversionfield was updated properly to2.0.0-rc.2with no other changes in dependencies or configuration.packages/strategy-tests/Cargo.toml (1)
3-3: Consistent version bump to 2.0.0-rc.2
Thestrategy-testscrate version is correctly incremented to2.0.0-rc.2, in line with the repository-wide release candidate update.packages/rs-platform-value/Cargo.toml (1)
5-5: Consistent version bump to 2.0.0-rc.2
Theplatform-valuecrate version has been updated to2.0.0-rc.2without any extraneous changes to dependencies or feature flags.packages/withdrawals-contract/Cargo.toml (1)
4-4: Version bump approved for withdrawals‑contract
The crate version has been correctly updated from2.0.0-rc.1to2.0.0-rc.2, aligning with the coordinated release candidate update.packages/rs-drive-abci/Cargo.toml (1)
3-3: Version bump approved for drive-abci
Thedrive-abcipackage version has been updated to2.0.0-rc.2with no unintended side effects.packages/wasm-dpp/Cargo.toml (1)
3-3: Version bump approved for wasm-dpp
Updated the package version to2.0.0-rc.2—consistent with the rest of the platform crates.packages/js-dapi-client/package.json (1)
3-3: Version bump approved for @dashevo/dapi-client
Theversionfield inpackage.jsonhas been correctly set to2.0.0-rc.2.packages/rs-platform-serialization/Cargo.toml (1)
5-5: Version bump approved for platform-serialization
Crate version updated to2.0.0-rc.2, matching the coordinated release across all platform packages.packages/rs-drive-proof-verifier/Cargo.toml (1)
3-3: Version bump to 2.0.0-rc.2 looks correct and isolated.
No other metadata or dependencies were altered, and this aligns with the coordinated release plan.packages/check-features/Cargo.toml (1)
3-3: Updatedcheck-featuresversion to 2.0.0-rc.2 as intended.
All other fields remain unchanged and consistent with the release bump.packages/simple-signer/Cargo.toml (1)
3-3: Version updated to 2.0.0-rc.2.
The rest of the manifest (edition, dependencies) is unchanged and correct.packages/dashpay-contract/Cargo.toml (1)
4-4: dashpay-contract version bump to 2.0.0-rc.2 is consistent.
No dependency or feature changes accompany this update.packages/wallet-utils-contract/Cargo.toml (1)
4-4: wallet-utils-contract version incremented to 2.0.0-rc.2 as expected.
All other configuration and dependencies are untouched.packages/token-history-contract/Cargo.toml (1)
4-4: Version bump to 2.0.0-rc.2
The crate version has been correctly updated from2.0.0-rc.1to2.0.0-rc.2. No other changes detected.packages/js-grpc-common/package.json (1)
3-3: Version bump to 2.0.0-rc.2
The package version has been updated from2.0.0-rc.1to2.0.0-rc.2, matching the coordinated repository release.packages/dashpay-contract/package.json (1)
3-3: Version bump to 2.0.0-rc.2
Updated the package version from2.0.0-rc.1to2.0.0-rc.2in line with the RC2 rollout.packages/wallet-utils-contract/package.json (1)
3-3: Version bump to 2.0.0-rc.2
The version field has been bumped from2.0.0-rc.1to2.0.0-rc.2, consistent with other contract packages.packages/feature-flags-contract/package.json (1)
3-3: Version bump to 2.0.0-rc.2
Package version updated from2.0.0-rc.1to2.0.0-rc.2, aligning with the repository-wide version update.packages/masternode-reward-shares-contract/package.json (1)
3-3: Approve version bump in masternode-reward-shares-contract
The version field has been correctly updated from2.0.0-rc.1to2.0.0-rc.2, matching the coordinated release across packages.package.json (1)
3-3: Approve root package version bump
The root@dashevo/platformpackage version is updated to2.0.0-rc.2, in line with the other workspace packages.packages/bench-suite/package.json (1)
4-4: Approve version bump in bench-suite
Updated the@dashevo/bench-suiteversion to2.0.0-rc.2, consistent with the global release candidate update.packages/dpns-contract/package.json (1)
3-3: Approve version bump in dpns-contract
The@dashevo/dpns-contractversion has been correctly incremented to2.0.0-rc.2, aligning with the other contracts.packages/platform-test-suite/package.json (1)
4-4: Approve version bump in platform-test-suite
The@dashevo/platform-test-suiteversion field is now2.0.0-rc.2, consistent with the overall release candidate version bump.packages/withdrawals-contract/package.json (1)
3-3: Version bump looks good.The package version has been correctly updated from
2.0.0-rc.1to2.0.0-rc.2as part of the coordinated version update across multiple packages in the repository.packages/dashmate/package.json (1)
3-3: Version bump looks good.The package version has been correctly updated from
2.0.0-rc.1to2.0.0-rc.2as part of the coordinated version update across multiple packages in the repository.packages/dapi-grpc/Cargo.toml (1)
4-4: Version bump looks good.The Rust package version has been correctly updated from
2.0.0-rc.1to2.0.0-rc.2as part of the coordinated version update across multiple packages in the repository.packages/rs-dapi-grpc-macros/Cargo.toml (1)
4-4: Version bump for dapi-grpc-macros crate
The crate’s version has been updated from2.0.0-rc.1to2.0.0-rc.2without modifying any other fields. This aligns with the coordinated release across the workspace.packages/dapi-grpc/package.json (1)
3-4: Version bump for @dashevo/dapi-grpc
Theversionfield has been updated from2.0.0-rc.1to2.0.0-rc.2and all other metadata remains unchanged, maintaining consistency with the new release candidate.
Summary by CodeRabbit