chore(release): update changelog and bump version to 2.1.0-dev.6 #2785
Conversation
WalkthroughRepository-wide version bumps from dev.5 to dev.6 across JS packages and Rust crates, plus a new 2.1.0-dev.6 section added to CHANGELOG.md. No code, API, dependency, or control-flow changes are included. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (116)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ gRPC Query Coverage Report |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/rs-drive/Cargo.toml (1)
6-10: Author entry likely has a typo (missing '>').The string for "Wisdom Ogwu" lacks the closing '>' around the email, unlike the others. Not a TOML error, but inconsistent metadata.
Apply:
- "Wisdom Ogwu <wisdom@dash.org", + "Wisdom Ogwu <wisdom@dash.org>",
🧹 Nitpick comments (2)
packages/rs-platform-value-convertible/Cargo.toml (1)
4-4: Fix typo in description ("Convertion" → "Conversion").Apply:
-description = "Convertion to and from platform values" +description = "Conversion to and from platform values"packages/rs-context-provider/Cargo.toml (1)
12-12: Consider aligning thiserror to 2.x used elsewhere in the workspace.Helps avoid duplicate deps and reduces build graph complexity. Can be a follow-up, not blocking this release.
-thiserror = "1.0" +thiserror = "2.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (59)
CHANGELOG.md(1 hunks)package.json(1 hunks)packages/bench-suite/package.json(1 hunks)packages/check-features/Cargo.toml(1 hunks)packages/dapi-grpc/Cargo.toml(1 hunks)packages/dapi-grpc/package.json(1 hunks)packages/dapi/package.json(1 hunks)packages/dash-platform-balance-checker/Cargo.toml(1 hunks)packages/dash-spv/package.json(1 hunks)packages/dashmate/package.json(1 hunks)packages/dashpay-contract/Cargo.toml(1 hunks)packages/dashpay-contract/package.json(1 hunks)packages/data-contracts/Cargo.toml(1 hunks)packages/dpns-contract/Cargo.toml(1 hunks)packages/dpns-contract/package.json(1 hunks)packages/feature-flags-contract/Cargo.toml(1 hunks)packages/feature-flags-contract/package.json(1 hunks)packages/js-dapi-client/package.json(1 hunks)packages/js-dash-sdk/package.json(1 hunks)packages/js-evo-sdk/package.json(1 hunks)packages/js-grpc-common/package.json(1 hunks)packages/keyword-search-contract/Cargo.toml(1 hunks)packages/keyword-search-contract/package.json(1 hunks)packages/masternode-reward-shares-contract/Cargo.toml(1 hunks)packages/masternode-reward-shares-contract/package.json(1 hunks)packages/platform-test-suite/package.json(1 hunks)packages/rs-context-provider/Cargo.toml(1 hunks)packages/rs-dapi-client/Cargo.toml(1 hunks)packages/rs-dapi-grpc-macros/Cargo.toml(1 hunks)packages/rs-dpp/Cargo.toml(1 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)packages/rs-drive-proof-verifier/Cargo.toml(1 hunks)packages/rs-drive/Cargo.toml(1 hunks)packages/rs-json-schema-compatibility-validator/Cargo.toml(1 hunks)packages/rs-platform-serialization-derive/Cargo.toml(1 hunks)packages/rs-platform-serialization/Cargo.toml(1 hunks)packages/rs-platform-value-convertible/Cargo.toml(1 hunks)packages/rs-platform-value/Cargo.toml(1 hunks)packages/rs-platform-version/Cargo.toml(1 hunks)packages/rs-platform-versioning/Cargo.toml(1 hunks)packages/rs-platform-wallet/Cargo.toml(1 hunks)packages/rs-sdk-ffi/Cargo.toml(1 hunks)packages/rs-sdk-trusted-context-provider/Cargo.toml(1 hunks)packages/rs-sdk/Cargo.toml(1 hunks)packages/simple-signer/Cargo.toml(1 hunks)packages/strategy-tests/Cargo.toml(1 hunks)packages/token-history-contract/Cargo.toml(1 hunks)packages/token-history-contract/package.json(1 hunks)packages/wallet-lib/package.json(1 hunks)packages/wallet-utils-contract/Cargo.toml(1 hunks)packages/wallet-utils-contract/package.json(1 hunks)packages/wasm-dpp/Cargo.toml(1 hunks)packages/wasm-dpp/package.json(1 hunks)packages/wasm-drive-verify/Cargo.toml(1 hunks)packages/wasm-drive-verify/package.json(1 hunks)packages/wasm-sdk/Cargo.toml(1 hunks)packages/wasm-sdk/package.json(1 hunks)packages/withdrawals-contract/Cargo.toml(1 hunks)packages/withdrawals-contract/package.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
packages/platform-test-suite/**
📄 CodeRabbit inference engine (AGENTS.md)
packages/platform-test-suite/**: Keep end-to-end tests and helpers in packages/platform-test-suite
Keep all E2E tests exclusively in packages/platform-test-suite
Files:
packages/platform-test-suite/package.json
packages/rs-sdk-ffi/**
📄 CodeRabbit inference engine (AGENTS.md)
Keep iOS/FFI Rust SDK artifacts in packages/rs-sdk-ffi
Files:
packages/rs-sdk-ffi/Cargo.toml
packages/wasm-sdk/**
📄 CodeRabbit inference engine (CLAUDE.md)
Keep WASM SDK docs in sync (run generate_docs.py) when updating the WASM SDK
Files:
packages/wasm-sdk/Cargo.tomlpackages/wasm-sdk/package.json
🧠 Learnings (18)
📚 Learning: 2025-09-12T13:18:08.661Z
Learnt from: CR
PR: dashpay/platform#0
File: AGENTS.md:0-0
Timestamp: 2025-09-12T13:18:08.661Z
Learning: Applies to packages/platform-test-suite/** : Keep end-to-end tests and helpers in packages/platform-test-suite
Applied to files:
packages/platform-test-suite/package.json
📚 Learning: 2025-01-19T07:36:46.042Z
Learnt from: QuantumExplorer
PR: dashpay/platform#2431
File: packages/rs-drive/Cargo.toml:55-60
Timestamp: 2025-01-19T07:36:46.042Z
Learning: The grovedb dependencies in packages/rs-drive/Cargo.toml and related files are intentionally kept at specific revisions rather than using the latest stable version, with plans to update them at a later time.
Applied to files:
packages/rs-drive-proof-verifier/Cargo.tomlpackages/rs-platform-value-convertible/Cargo.tomlpackages/wasm-drive-verify/Cargo.tomlpackages/rs-platform-versioning/Cargo.tomlpackages/rs-drive-abci/Cargo.tomlpackages/rs-platform-serialization/Cargo.tomlpackages/rs-sdk-ffi/Cargo.tomlpackages/rs-sdk/Cargo.tomlpackages/rs-dapi-grpc-macros/Cargo.tomlpackages/rs-platform-version/Cargo.tomlpackages/rs-drive/Cargo.tomlpackages/rs-platform-value/Cargo.toml
📚 Learning: 2024-12-05T09:29:38.918Z
Learnt from: shumkov
PR: dashpay/platform#2375
File: packages/rs-drive-abci/Cargo.toml:61-63
Timestamp: 2024-12-05T09:29:38.918Z
Learning: In the `drive-abci` package, avoid adding unused dependencies like `hashbrown` to `Cargo.toml`. The team relies on CI to detect dependency version issues.
Applied to files:
packages/rs-drive-proof-verifier/Cargo.tomlpackages/rs-drive-abci/Cargo.toml
📚 Learning: 2025-09-22T05:59:31.140Z
Learnt from: shumkov
PR: dashpay/platform#2783
File: packages/js-evo-sdk/tests/functional/dpns.spec.mjs:2-2
Timestamp: 2025-09-22T05:59:31.140Z
Learning: The dist/evo-sdk.module.js file in packages/js-evo-sdk is a generated build artifact created during the build process, not a source file that should exist in the repository.
Applied to files:
packages/js-evo-sdk/package.json
📚 Learning: 2024-10-08T13:28:03.529Z
Learnt from: QuantumExplorer
PR: dashpay/platform#2227
File: packages/rs-drive-abci/src/platform_types/platform_state/mod.rs:141-141
Timestamp: 2024-10-08T13:28:03.529Z
Learning: When converting `PlatformStateV0` to `PlatformStateForSavingV1` in `packages/rs-drive-abci/src/platform_types/platform_state/mod.rs`, only version `0` needs to be handled in the match on `platform_state_for_saving_structure_default` because the changes are retroactive.
Applied to files:
packages/rs-platform-value-convertible/Cargo.tomlpackages/rs-platform-versioning/Cargo.tomlpackages/rs-platform-version/Cargo.tomlpackages/rs-platform-value/Cargo.toml
📚 Learning: 2024-10-18T15:39:51.172Z
Learnt from: lklimek
PR: dashpay/platform#2254
File: packages/rs-sdk/src/sdk.rs:585-585
Timestamp: 2024-10-18T15:39:51.172Z
Learning: The 'platform' project uses Rust version 1.80, so code in 'packages/rs-sdk' can use features available in Rust 1.80, such as the `abs_diff()` method.
Applied to files:
packages/rs-platform-value-convertible/Cargo.tomlpackages/rs-platform-versioning/Cargo.tomlpackages/rs-platform-serialization/Cargo.tomlpackages/rs-sdk-ffi/Cargo.tomlpackages/rs-sdk/Cargo.tomlpackages/rs-platform-wallet/Cargo.tomlpackages/rs-platform-version/Cargo.tomlpackages/wasm-sdk/Cargo.tomlpackages/rs-platform-value/Cargo.toml
📚 Learning: 2025-09-03T16:37:11.605Z
Learnt from: QuantumExplorer
PR: dashpay/platform#2756
File: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_list/update_state_masternode_list/v0/mod.rs:11-11
Timestamp: 2025-09-03T16:37:11.605Z
Learning: In packages/rs-dpp/Cargo.toml, the abci feature already includes core_rpc_client, and core_rpc_client is defined as ["dep:dashcore-rpc"]. This means rs-drive-abci can access dashcore-rpc types through dpp when using the abci feature.
Applied to files:
packages/rs-drive-abci/Cargo.tomlpackages/rs-dapi-client/Cargo.toml
📚 Learning: 2024-10-09T00:22:57.778Z
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-drive-abci/tests/strategy_tests/main.rs:1162-1162
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the Rust test file `packages/rs-drive-abci/tests/strategy_tests/main.rs`, specific protocol versions like `PROTOCOL_VERSION_1` are intentionally used in tests instead of `PROTOCOL_VERSION_LATEST`.
Applied to files:
packages/rs-drive-abci/Cargo.toml
📚 Learning: 2025-01-24T07:54:55.723Z
Learnt from: QuantumExplorer
PR: dashpay/platform#2440
File: packages/rs-drive-abci/Cargo.toml:76-76
Timestamp: 2025-01-24T07:54:55.723Z
Learning: In the drive-abci package, bls-signatures is intentionally declared twice:
1. As an optional dependency in [dependencies] to make it an optional feature in production
2. As a non-optional dependency in [dev-dependencies] to ensure it's always available for tests
Applied to files:
packages/rs-drive-abci/Cargo.toml
📚 Learning: 2024-10-03T11:51:06.980Z
Learnt from: shumkov
PR: dashpay/platform#2201
File: packages/rs-platform-version/src/version/v2.rs:1186-1188
Timestamp: 2024-10-03T11:51:06.980Z
Learning: In the `IdentityTransitionVersions` structure within `packages/rs-platform-version/src/version/v2.rs`, the field `credit_withdrawal` does not need the `identity_` prefix since it is already encompassed within identity state transitions.
Applied to files:
packages/withdrawals-contract/Cargo.toml
📚 Learning: 2025-09-12T13:18:08.661Z
Learnt from: CR
PR: dashpay/platform#0
File: AGENTS.md:0-0
Timestamp: 2025-09-12T13:18:08.661Z
Learning: Applies to packages/rs-sdk-ffi/** : Keep iOS/FFI Rust SDK artifacts in packages/rs-sdk-ffi
Applied to files:
packages/rs-sdk-ffi/Cargo.tomlpackages/rs-sdk/Cargo.toml
📚 Learning: 2025-09-07T22:18:50.883Z
Learnt from: CR
PR: dashpay/platform#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-07T22:18:50.883Z
Learning: Applies to packages/rs-sdk-ffi/**/*.{h,rs} : Follow unified SDK function prefixes: dash_core_sdk_* for Core, dash_sdk_* for Platform, dash_unified_sdk_* for unified APIs
Applied to files:
packages/rs-sdk-ffi/Cargo.tomlpackages/rs-sdk/Cargo.toml
📚 Learning: 2024-10-29T10:42:00.521Z
Learnt from: lklimek
PR: dashpay/platform#2277
File: packages/rs-dapi-client/Cargo.toml:22-22
Timestamp: 2024-10-29T10:42:00.521Z
Learning: In `packages/rs-dapi-client/Cargo.toml`, `backon` will not work without the `tokio-sleep` feature in our setup, so it's unnecessary to declare `tokio-sleep` as a separate feature in the `[features]` section.
Applied to files:
packages/rs-sdk/Cargo.tomlpackages/rs-dapi-client/Cargo.toml
📚 Learning: 2025-09-12T13:18:08.661Z
Learnt from: CR
PR: dashpay/platform#0
File: AGENTS.md:0-0
Timestamp: 2025-09-12T13:18:08.661Z
Learning: Applies to packages/rs-*/**/*.rs : Keep Rust code clippy-clean (cargo clippy)
Applied to files:
packages/rs-sdk/Cargo.toml
📚 Learning: 2025-03-11T09:39:23.071Z
Learnt from: shumkov
PR: dashpay/platform#2489
File: packages/rs-dpp/Cargo.toml:32-32
Timestamp: 2025-03-11T09:39:23.071Z
Learning: In the Dash Platform project, dependencies are currently managed using Git repository references with tags (repo+tag format in Cargo.toml) rather than published crates, as the team is not currently publishing crates to crates.io.
Applied to files:
packages/rs-sdk/Cargo.toml
📚 Learning: 2025-09-07T22:19:59.217Z
Learnt from: CR
PR: dashpay/platform#0
File: packages/swift-sdk/SwiftExampleApp/CLAUDE.md:0-0
Timestamp: 2025-09-07T22:19:59.217Z
Learning: Applies to packages/swift-sdk/SwiftExampleApp/**/*.swift : Use Platform SDK functions with the dash_sdk_* prefix
Applied to files:
packages/rs-sdk/Cargo.toml
📚 Learning: 2025-09-07T22:18:50.883Z
Learnt from: CR
PR: dashpay/platform#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-07T22:18:50.883Z
Learning: Applies to packages/wasm-sdk/** : Keep WASM SDK docs in sync (run generate_docs.py) when updating the WASM SDK
Applied to files:
packages/wasm-sdk/Cargo.tomlpackages/wasm-sdk/package.json
📚 Learning: 2025-09-03T14:42:29.958Z
Learnt from: thephez
PR: dashpay/platform#2754
File: packages/wasm-sdk/docs.html:1970-1971
Timestamp: 2025-09-03T14:42:29.958Z
Learning: In packages/wasm-sdk/, the docs.html file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in docs.html, as manual changes to docs.html would be overwritten during regeneration.
Applied to files:
packages/wasm-sdk/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (140)
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Rust packages (dpns-contract) / Tests
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Rust packages (dpns-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Formatting
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Tests
- GitHub Check: Rust packages (masternode-reward-shares-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Unused dependencies
- GitHub Check: Rust packages (token-history-contract) / Formatting
- GitHub Check: Rust packages (token-history-contract) / Linting
- GitHub Check: Rust packages (token-history-contract) / Tests
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios-sim)
- GitHub Check: Build rs-sdk-ffi for iOS targets (aarch64-apple-ios)
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
🔇 Additional comments (58)
packages/rs-platform-wallet/Cargo.toml (1)
3-3: Version bump LGTMAligned with the release. No issues spotted.
packages/rs-platform-version/Cargo.toml (1)
5-5: Version bump LGTMConsistent with the coordinated release.
packages/wasm-drive-verify/Cargo.toml (1)
3-3: Version bump LGTMMatches the repo-wide dev.6 update.
packages/wasm-sdk/Cargo.toml (1)
3-3: Remember to sync WASM SDK docsPer repo guidelines for packages/wasm-sdk/**, run the docs generator after version bumps (generate_docs.py) and commit any changes.
Can you confirm docs were regenerated and updated in this PR?
packages/dash-spv/package.json (1)
3-3: Version bump LGTMNo additional changes detected.
packages/dash-platform-balance-checker/Cargo.toml (1)
3-3: Version bump LGTMConsistent with the release train.
packages/rs-json-schema-compatibility-validator/Cargo.toml (1)
3-3: Version bump LGTMAll good here.
package.json (1)
3-3: Root version bump LGTM — no lingering-dev.5versions foundRepo-wide search found only
-dev.6in package.json files; nodev.5occurrences in package.json or Cargo.toml.packages/js-grpc-common/package.json (1)
3-3: LGTM! Version bump correctly follows semantic versioning.The version update from 2.1.0-dev.5 to 2.1.0-dev.6 is properly formatted and consistent with the coordinated release across the repository.
packages/masternode-reward-shares-contract/package.json (1)
3-3: LGTM! Version increment follows proper semantic versioning format.The pre-release version bump from 2.1.0-dev.5 to 2.1.0-dev.6 is correctly formatted and aligns with the coordinated release.
packages/rs-platform-serialization-derive/Cargo.toml (1)
5-5: LGTM! Consistent version bump across Rust crates.The version update follows the established pattern and maintains consistency with other packages in this coordinated release.
packages/rs-sdk/Cargo.toml (1)
3-3: LGTM! SDK version correctly bumped.The dash-sdk version bump is consistent with the release pattern and aligns with the coordinated version updates across all packages.
packages/wallet-utils-contract/Cargo.toml (1)
4-4: LGTM! Contract version update follows semantic versioning.The version bump maintains consistency across the workspace packages and follows proper semantic versioning conventions.
packages/dapi/package.json (1)
4-4: LGTM! DAPI package version correctly updated.The version increment is consistent with the coordinated release and follows semantic versioning standards with the pre-release identifier.
packages/dashmate/package.json (1)
3-3: LGTM! Dashmate version bump aligns with release.The version update maintains consistency across all packages in the workspace and follows the established versioning pattern.
packages/rs-dapi-client/Cargo.toml (1)
3-3: LGTM! Rust DAPI client version correctly incremented.The version bump from 2.1.0-dev.5 to 2.1.0-dev.6 is consistent with the coordinated release and follows proper semantic versioning format.
packages/rs-platform-value-convertible/Cargo.toml (1)
5-5: LGTM on version bump.packages/wasm-drive-verify/package.json (1)
6-6: LGTM; version aligned.packages/dpns-contract/package.json (1)
3-3: LGTM; version aligned.packages/rs-platform-value/Cargo.toml (1)
5-5: LGTM on version bump.packages/withdrawals-contract/package.json (1)
3-3: LGTM; version aligned.packages/rs-context-provider/Cargo.toml (1)
3-3: LGTM on version bump.packages/rs-sdk-ffi/Cargo.toml (1)
3-3: Version bump OK — confirm FFI headers location & regenerate cbindgen output if neededFound FFI headers in packages/rs-sdk-ffi: packages/rs-sdk-ffi/include/dash_sdk_ffi.h, packages/rs-sdk-ffi/test_header.h; found .h files outside rs-sdk-ffi: packages/dapi-grpc/clients/core/v0/objective-c/Core.pbobjc.h, packages/dapi-grpc/clients/core/v0/objective-c/Core.pbrpc.h, packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h, packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbrpc.h, packages/swift-sdk/SwiftTests/Sources/SwiftDashSDKMock/SwiftDashSDK.h, packages/swift-sdk/SwiftTests/SwiftDashSDK.h — confirm those are unrelated to the Rust FFI (protobuf/Obj‑C or test headers). If any cbindgen-generated headers contain version info, regenerate and commit updated headers so packages/rs-sdk-ffi/include/dash_sdk_ffi.h reflects 2.1.0-dev.6.
packages/dapi-grpc/package.json (1)
3-3: LGTM — all workspace packages are on -dev.6. Verification found no package.json with a version missing the -dev.6 suffix.packages/rs-drive/Cargo.toml (1)
4-4: Version updated correctly.packages/wallet-utils-contract/package.json (1)
3-3: Version bump OK.packages/simple-signer/Cargo.toml (1)
3-3: Version bump OK.packages/token-history-contract/package.json (1)
3-3: Version bump OK.packages/rs-platform-serialization/Cargo.toml (1)
5-5: Version bump OK.packages/token-history-contract/Cargo.toml (1)
4-4: Version bump OK.packages/keyword-search-contract/Cargo.toml (1)
4-4: Version bump OK.packages/wasm-dpp/package.json (1)
3-3: Version bump approved — no lingering 2.1.0-dev.5 referencesRan repo-wide and manifest-specific searches; no occurrences of 2.1.0-dev.5 found.
packages/js-dapi-client/package.json (1)
3-3: Version bump LGTM.Aligned with the coordinated release.
packages/wasm-dpp/Cargo.toml (1)
3-3: Version bump LGTM.No functional changes detected.
packages/keyword-search-contract/package.json (1)
3-3: Version bump LGTM.Matches the monorepo release.
packages/strategy-tests/Cargo.toml (1)
3-3: Version bump LGTM.No other changes.
packages/dpns-contract/Cargo.toml (1)
4-4: Version bump LGTM.Consistent with the rest of the release.
packages/withdrawals-contract/Cargo.toml (1)
4-4: Version bump LGTM.No other modifications.
packages/wallet-lib/package.json (1)
3-3: Version bump LGTM — verify no lingering -dev.5Sandbox rg produced no output (may mean none found or a sandbox/tool limitation). Re-run locally and confirm: rg -nP '\b(dev.5)\b' -g 'package.json' -g 'Cargo.toml' -S
packages/rs-dpp/Cargo.toml (1)
3-3: LGTM: Version bump follows semantic versioning for dev release.The version update from "2.1.0-dev.5" to "2.1.0-dev.6" follows semantic versioning pre-release conventions, where pre-release identifiers are used to label versions in experimental or development phase using dot-separated identifiers like "dev.6". This is a standard approach for development releases within the same minor version.
packages/dashpay-contract/package.json (1)
3-3: LGTM: Version bump aligns with semantic versioning conventions.The version increment from "2.1.0-dev.5" to "2.1.0-dev.6" follows proper pre-release labeling format for development versions. This coordinated version bump across multiple packages is consistent with the PR's objective of releasing version 2.1.0-dev.6.
packages/check-features/Cargo.toml (1)
3-3: LGTM: Development version increment is properly formatted.The version update to "2.1.0-dev.6" uses the correct pre-release identifier format for development versions. This change is consistent with the coordinated version bump across the repository.
packages/js-evo-sdk/package.json (1)
3-3: LGTM: Version bump follows semantic versioning standards.The version change from "2.1.0-dev.5" to "2.1.0-dev.6" properly uses pre-release identifiers for development versions. This aligns with the repository-wide version bump strategy for the 2.1.0-dev.6 release.
packages/data-contracts/Cargo.toml (1)
4-4: LGTM: Version update maintains semantic versioning compliance.The version increment to "2.1.0-dev.6" uses proper pre-release identifier format for development phases. This change is part of the coordinated version bump across all packages in the repository.
packages/rs-drive-proof-verifier/Cargo.toml (1)
3-3: LGTM: Development version increment follows proper conventions.The version update to "2.1.0-dev.6" correctly uses pre-release identifier format for development versions. This change maintains consistency with the repository-wide version bump for the 2.1.0-dev.6 release.
packages/dashpay-contract/Cargo.toml (1)
4-4: LGTM: Version bump properly formatted for development release.The version change to "2.1.0-dev.6" uses correct pre-release labeling with dot-separated identifiers for development versions. This aligns with the coordinated version increment across the entire codebase.
packages/masternode-reward-shares-contract/Cargo.toml (1)
4-4: LGTM: Version update follows semantic versioning best practices.The version increment to "2.1.0-dev.6" properly uses pre-release identifier format for development phases. This change is consistent with the repository-wide coordinated version bump strategy.
packages/dapi-grpc/Cargo.toml (1)
4-4: LGTM: dapi-grpc crate version bumped to 2.1.0-dev.6No manifest or feature changes beyond the version, which aligns with the release-only PR.
packages/js-dash-sdk/package.json (1)
3-3: LGTM: js-dash-sdk version set to 5.1.0-dev.6No other changes; matches the coordinated version bump.
packages/bench-suite/package.json (1)
4-4: LGTM: bench-suite version bumped to 2.1.0-dev.6No functional changes; aligns with release.
packages/rs-drive-abci/Cargo.toml (1)
3-3: LGTM: drive-abci crate version bumped to 2.1.0-dev.6Dependencies and features unchanged; intentional bls-signatures setup remains intact.
packages/rs-platform-versioning/Cargo.toml (1)
5-5: LGTM: platform-versioning crate version -> 2.1.0-dev.6No other changes; consistent with PR scope.
packages/platform-test-suite/package.json (1)
4-4: LGTM: platform-test-suite version bumped to 2.1.0-dev.6E2E tests remain in the designated package per guidelines.
packages/rs-sdk-trusted-context-provider/Cargo.toml (1)
3-3: LGTM: rs-sdk-trusted-context-provider version -> 2.1.0-dev.6Manifest otherwise unchanged.
packages/rs-dapi-grpc-macros/Cargo.toml (1)
4-4: LGTM — version bump to 2.1.0-dev.6 (verified)
No lingering dev.5 versions in Cargo.toml/package.json; CHANGELOG.md contains the 2.1.0-dev.6 entry.CHANGELOG.md (1)
1-13: LGTM: new 2.1.0-dev.6 entry reads clean and matches scopeRelease notes are clear and follow the existing format.
Please verify the compare link and issue references resolve after tagging (v2.1.0-dev.6). If your release tooling doesn’t auto-validate, a quick manual check post-tag is sufficient.
packages/feature-flags-contract/package.json (1)
3-3: LGTM — package version bumped to 2.1.0-dev.6No leftover "2.1.0-dev.5" found; workspace package.json files were verified and show 2.1.0-dev.6.
packages/feature-flags-contract/Cargo.toml (1)
4-4: LGTM — workspace versions updated to 2.1.0-dev.6No leftover "2.1.0-dev.5" found; Cargo.toml and package.json entries across packages show "2.1.0-dev.6".
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "8b39187a1e33c340b1f33a1146672810b99033d7f576a832b009b57d074910ae"
)Xcode manual integration:
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h (1)
7149-7169: Breaking wire compatibility: BurnEvent field renumbering
PublicNoteappears to have changed field number (now 3) andBurnFromIdtook 2. Changing existing field numbers breaks backward compatibility for serialized messages. Add the new field with a new number and keep existing numbers stable.Apply in the proto and regenerate (illustrative header diff below to show intended numbering preservation):
typedef GPB_ENUM(GetGroupActionsResponse_GetGroupActionsResponseV0_BurnEvent_FieldNumber) { GetGroupActionsResponse_GetGroupActionsResponseV0_BurnEvent_FieldNumber_Amount = 1, - GetGroupActionsResponse_GetGroupActionsResponseV0_BurnEvent_FieldNumber_BurnFromId = 2, - GetGroupActionsResponse_GetGroupActionsResponseV0_BurnEvent_FieldNumber_PublicNote = 3, + GetGroupActionsResponse_GetGroupActionsResponseV0_BurnEvent_FieldNumber_PublicNote = 2, + GetGroupActionsResponse_GetGroupActionsResponseV0_BurnEvent_FieldNumber_BurnFromId = 3, };Note: Fix the .proto (keep PublicNote at its original tag; assign BurnFromId a new unused tag) and re-run codegen.
🧹 Nitpick comments (3)
packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py (1)
353-358: Silence ARG002 in generated unimplemented servicer methods (optional).Ruff flags unused
requestin unimplemented stubs. Consider excluding generated directories from linting or prefixing args with_in templates to suppress noise.packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h (1)
2546-2592: Avoid naming confusion and clean up user-facing comment
- Field name
proofhere is not of typeProof(it’sIdentityProvedResponse). This diverges from other responses whereproofalways carriesProof. Consider renaming toidentityProofs(or similar) in the proto to avoid API ambiguity.- Replace “A hack, we return 2 proofs” with a neutral explanation (e.g., “Returns two proofs: GroveDB PK-hash proof and identity proof bytes.”).
packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts (1)
7075-7130: Consider 64‑bit safety for direct purchase price fieldsDownstream response types include numeric prices/quantities. If underlying proto uses 64‑bit ints, mapping to
numberrisks precision loss in JS. Preferstringmapping for 64‑bit numeric fields or use wrappers with JS string option, then regenerate.Please confirm the proto field types for fixed/variable prices and quantities. If any are int64/uint64, we should switch to string representation in the proto TS mapping before release.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (10)
packages/dapi-grpc/clients/platform/v0/java/org/dash/platform/dapi/v0/PlatformGrpc.java(27 hunks)packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h(10 hunks)packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbrpc.h(9 hunks)packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbrpc.m(4 hunks)packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py(13 hunks)packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts(8 hunks)packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.d.ts(10 hunks)packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.js(8 hunks)packages/dashmate/configs/defaults/getBaseConfigFactory.js(1 hunks)packages/dashmate/configs/getConfigFileMigrationsFactory.js(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
packages/**/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
packages/**/**/*.{js,ts,jsx,tsx}: Adhere to ESLint with Airbnb/TypeScript configs for JS/TS code
Use camelCase for JS/TS variables and functions
Use PascalCase for JS/TS classes
Prefer kebab-case filenames within JS packages
Files:
packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.jspackages/dashmate/configs/getConfigFileMigrationsFactory.jspackages/dashmate/configs/defaults/getBaseConfigFactory.jspackages/dapi-grpc/clients/platform/v0/web/platform_pb_service.d.tspackages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts
🧬 Code graph analysis (8)
packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.js (2)
packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py (9)
Platform(789-1589)getIdentityByNonUniquePublicKeyHash(353-357)getIdentityByNonUniquePublicKeyHash(1065-1079)getFinalizedEpochInfos(389-393)getFinalizedEpochInfos(1167-1181)getTokenContractInfo(496-500)getTokenContractInfo(1456-1470)getTokenPerpetualDistributionLastClaim(508-512)getTokenPerpetualDistributionLastClaim(1490-1504)packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.d.ts (1)
Platform(430-479)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
.pnp.cjs (3)
options(24516-24516)options(24583-24583)options(27852-27852)
packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py (1)
packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts (8)
GetIdentityByNonUniquePublicKeyHashRequest(2562-2577)GetIdentityByNonUniquePublicKeyHashResponse(2624-2639)GetFinalizedEpochInfosRequest(3565-3580)GetFinalizedEpochInfosResponse(3629-3644)GetTokenContractInfoRequest(7309-7324)GetTokenContractInfoResponse(7363-7378)GetTokenPerpetualDistributionLastClaimRequest(7701-7716)GetTokenPerpetualDistributionLastClaimResponse(7793-7808)
packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbrpc.h (2)
packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts (8)
GetFinalizedEpochInfosRequest(3565-3580)GetFinalizedEpochInfosResponse(3629-3644)GetIdentityByNonUniquePublicKeyHashRequest(2562-2577)GetIdentityByNonUniquePublicKeyHashResponse(2624-2639)GetTokenContractInfoRequest(7309-7324)GetTokenContractInfoResponse(7363-7378)GetTokenPerpetualDistributionLastClaimRequest(7701-7716)GetTokenPerpetualDistributionLastClaimResponse(7793-7808)packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py (8)
getIdentityByNonUniquePublicKeyHash(353-357)getIdentityByNonUniquePublicKeyHash(1065-1079)getFinalizedEpochInfos(389-393)getFinalizedEpochInfos(1167-1181)getTokenContractInfo(496-500)getTokenContractInfo(1456-1470)getTokenPerpetualDistributionLastClaim(508-512)getTokenPerpetualDistributionLastClaim(1490-1504)
packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.d.ts (2)
packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py (1)
Platform(789-1589)packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts (8)
GetIdentityByNonUniquePublicKeyHashRequest(2562-2577)GetIdentityByNonUniquePublicKeyHashResponse(2624-2639)GetFinalizedEpochInfosRequest(3565-3580)GetFinalizedEpochInfosResponse(3629-3644)GetTokenContractInfoRequest(7309-7324)GetTokenContractInfoResponse(7363-7378)GetTokenPerpetualDistributionLastClaimRequest(7701-7716)GetTokenPerpetualDistributionLastClaimResponse(7793-7808)
packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h (2)
packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts (1)
Proof(9-44)packages/js-evo-sdk/src/tokens/facade.ts (1)
contractInfo(92-95)
packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts (1)
packages/dapi-grpc/clients/drive/v0/web/drive_pb.d.ts (2)
AsObject(24-26)AsObject(51-54)
packages/dapi-grpc/clients/platform/v0/java/org/dash/platform/dapi/v0/PlatformGrpc.java (2)
packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts (8)
GetIdentityByNonUniquePublicKeyHashRequest(2562-2577)GetIdentityByNonUniquePublicKeyHashResponse(2624-2639)GetFinalizedEpochInfosRequest(3565-3580)GetFinalizedEpochInfosResponse(3629-3644)GetTokenContractInfoRequest(7309-7324)GetTokenContractInfoResponse(7363-7378)GetTokenPerpetualDistributionLastClaimRequest(7701-7716)GetTokenPerpetualDistributionLastClaimResponse(7793-7808)packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py (10)
getIdentityByNonUniquePublicKeyHash(353-357)getIdentityByNonUniquePublicKeyHash(1065-1079)getFinalizedEpochInfos(389-393)getFinalizedEpochInfos(1167-1181)getTokenContractInfo(496-500)getTokenContractInfo(1456-1470)getTokenPreProgrammedDistributions(502-506)getTokenPreProgrammedDistributions(1473-1487)getTokenPerpetualDistributionLastClaim(508-512)getTokenPerpetualDistributionLastClaim(1490-1504)
🪛 Ruff (0.13.1)
packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py
353-353: Unused method argument: request
(ARG002)
389-389: Unused method argument: request
(ARG002)
496-496: Unused method argument: request
(ARG002)
502-502: Unused method argument: request
(ARG002)
508-508: Unused method argument: request
(ARG002)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (143)
- GitHub Check: Rust packages (rs-sdk-ffi) / Detect immutable structure changes
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (rs-sdk-ffi) / Detect immutable structure changes
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (rs-sdk-ffi) / Detect immutable structure changes
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (wasm-sdk) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive) / Unused dependencies
- GitHub Check: Rust packages (drive) / Tests
- GitHub Check: Rust packages (drive) / Linting
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
🔇 Additional comments (73)
packages/dashmate/configs/defaults/getBaseConfigFactory.js (1)
316-316: LGTM! Tenderdash Docker image updated to development version.This change updates the Tenderdash Docker image from
dashpay/tenderdash:1todashpay/tenderdash:1-dev, which aligns with the development version bump indicated in the PR title and is consistent with similar changes across the platform.packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1109-1109: LGTM! Migration properly updates Tenderdash Docker image.This migration entry correctly sets the Tenderdash Docker image to
dashpay/tenderdash:1-devfor the 2.1.0-dev.1 version, maintaining consistency with the base config changes and ensuring existing configurations are properly migrated to use the development version of the image.packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.js (8)
211-218: Service descriptor added: getFinalizedEpochInfos — LGTMMatches unary pattern and types.
364-371: Service descriptor added: getTokenContractInfo — LGTMConsistent with other token RPCs.
382-389: Service descriptor added: getTokenPerpetualDistributionLastClaim — LGTMConsistent naming and types.
939-968: Client stub added: getIdentityByNonUniquePublicKeyHash — LGTMFollows existing unary onEnd/error pattern with optional metadata.
1125-1154: Client stub added: getFinalizedEpochInfos — LGTMMatches generator conventions.
1652-1681: Client stub added: getTokenContractInfo — LGTMGood parity with service descriptor and d.ts overloads.
1714-1744: Client stub added: getTokenPerpetualDistributionLastClaim — LGTMConsistent with adjacent token methods.
157-164: Service descriptor added: getIdentityByNonUniquePublicKeyHash — verifiedDescriptor, client stubs, and request/response message types are present in JS (packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.js), TypeScript (.d.ts and platform_pb.d.ts), and Python (platform_pb2_grpc.py / platform__pb2); LGTM.
packages/dapi-grpc/clients/platform/v0/python/platform_pb2_grpc.py (15)
97-101: Stub method wired: getIdentityByNonUniquePublicKeyHash — LGTMCorrect RPC path and serializers.
127-131: Stub method wired: getFinalizedEpochInfos — LGTMMatches request/response types.
212-216: Stub method wired: getTokenContractInfo — LGTMConsistent unary_unary mapping.
222-226: Stub method wired: getTokenPerpetualDistributionLastClaim — LGTMCorrect path and type bindings.
389-394: Servicer stub added: getFinalizedEpochInfos — LGTMStandard UNIMPLEMENTED placeholder.
496-501: Servicer stub added: getTokenContractInfo — LGTMMatches generator style.
508-513: Servicer stub added: getTokenPerpetualDistributionLastClaim — LGTMConsistent with other stubs.
627-631: Server registration: getIdentityByNonUniquePublicKeyHash — LGTMHandler wiring and (de)serializers correct.
657-661: Server registration: getFinalizedEpochInfos — LGTMCorrect handler mapping.
742-746: Server registration: getTokenContractInfo — LGTMWiring looks correct.
752-756: Server registration: getTokenPerpetualDistributionLastClaim — LGTMConsistent with other token RPCs.
1064-1080: EXPERIMENTAL client: getIdentityByNonUniquePublicKeyHash — LGTMRPC path and serializers align.
1166-1182: EXPERIMENTAL client: getFinalizedEpochInfos — LGTMMatches service definition.
1455-1471: EXPERIMENTAL client: getTokenContractInfo — LGTMConsistent mapping.
1489-1505: EXPERIMENTAL client: getTokenPerpetualDistributionLastClaim — LGTMLooks good.
packages/dapi-grpc/clients/platform/v0/web/platform_pb_service.d.ts (12)
151-158: Type alias added: PlatformgetIdentityByNonUniquePublicKeyHash — LGTMDescriptor type matches request/response.
205-212: Type alias added: PlatformgetFinalizedEpochInfos — LGTM
358-365: Type alias added: PlatformgetTokenContractInfo — LGTM
376-383: Type alias added: PlatformgetTokenPerpetualDistributionLastClaim — LGTM
448-449: Platform static: getIdentityByNonUniquePublicKeyHash — LGTM
454-455: Platform static: getFinalizedEpochInfos — LGTM
471-471: Platform static: getTokenContractInfo — LGTM
473-473: Platform static: getTokenPerpetualDistributionLastClaim — LGTM
657-665: Client overloads: getIdentityByNonUniquePublicKeyHash — LGTMTwo-arg and three-arg overloads align with convention.
711-719: Client overloads: getFinalizedEpochInfos — LGTM
864-872: Client overloads: getTokenContractInfo — LGTM
882-890: Client overloads: getTokenPerpetualDistributionLastClaim — LGTMpackages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h (8)
83-87: LGTM: new finalized epoch infos forward declarationsInterfaces are consistent with the rest of the generated surface.
147-151: LGTM: new identity-by-non-unique-public-key-hash forward declarationsNames align with existing identity lookup surfaces.
196-199: LGTM: token contract info forward declarationsConsistent naming and versioning.
205-209: LGTM: token perpetual distribution last-claim forward declarationsMatches the new response types below.
3267-3483: LGTM: finalized epoch infos surfaceStructure (epochs list, proposers, fees, oneof for result) looks correct.
Please confirm 32-bit
blockCountis sufficient for the maximum possible blocks per epoch on mainnet.
5868-5924: LGTM: direct purchase prices requestDocs clearly state constraints; server-side should enforce non-empty and uniqueness.
6387-6553: LGTM: token perpetual distribution last-claim surfaceOneof for paidAt variants and clear helper are present.
Please confirm server guarantees exactly one of timestamp/blockHeight/epoch/rawBytes is set.
6098-6128: Verify client usage expects tokenId, not contractIdRequest requires a 32‑byte tokenId, but some client code refers to contractId. Ensure SDKs pass tokenId.
packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbrpc.m (4)
393-411: Add getIdentityByNonUniquePublicKeyHash RPC: LGTMClient, RPC object, and unary call variants are consistent with existing patterns.
513-531: Add getFinalizedEpochInfos RPC: LGTMSignatures and response marshalling match the new messages.
918-936: Add getTokenContractInfo RPC: LGTMConsistent naming and call construction.
958-976: Add getTokenPerpetualDistributionLastClaim RPC: LGTMUnary method creation aligns with the rest of the client.
packages/dapi-grpc/clients/platform/v0/java/org/dash/platform/dapi/v0/PlatformGrpc.java (9)
1635-1641: PlatformImplBase: added abstract handlers: LGTMServer-side hooks for the 4 new RPCs mirror existing pattern.
Also applies to: 1677-1683, 1811-1817, 1825-1831
1981-1987: bindService routing for new RPCs: LGTMAll four methods are registered and mapped to distinct METHODIDs.
Also applies to: 2024-2029, 2143-2149, 2157-2162
2344-2351: Async stub methods added: LGTMClient async calls for the new RPCs follow standard asyncUnaryCall usage.
Also applies to: 2392-2399, 2543-2550, 2561-2566
2734-2740: Blocking stub methods added: LGTMBlocking unary wrappers are correct.
Also applies to: 2776-2782, 2910-2916, 2924-2930
3109-3115: Future stub methods added: LGTMFuture-style stubs created with futureUnaryCall as expected.
Also applies to: 3157-3163, 3308-3314, 3324-3330
3389-3420: METHODID constants extended: LGTMIDs are unique and referenced correctly in handler switch. No collisions detected.
3502-3505: MethodHandlers switch updated: LGTMNew cases route to the correct PlatformImplBase methods.
Also applies to: 3526-3529, 3594-3597, 3602-3605
3703-3703: ServiceDescriptor includes new methods: LGTMAll four new RPCs are added to the descriptor, ensuring server advertises them.
Also applies to: 3709-3709, 3726-3726, 3728-3728
514-544: New method descriptors for 4 RPCs: LGTMDescriptors for getIdentityByNonUniquePublicKeyHash, getFinalizedEpochInfos, getTokenContractInfo, and getTokenPerpetualDistributionLastClaim are set up correctly (UNARY, full names, marshallers, schema descriptors).
Run to verify end-to-end presence across languages and method paths:
Also applies to: 700-730, 1227-1257, 1289-1319
packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbrpc.h (10)
44-45: LGTM! Forward declarations are correctly formatted.The forward class declarations for the new RPC message types follow standard Objective-C conventions and are consistent with existing code in the file.
Also applies to: 66-67, 92-93, 96-97
204-206: LGTM! New Platform2 protocol method is properly declared.The pragma mark and method declaration follow gRPC Objective-C conventions:
- Appropriate pragma mark with method signature description
- Method name follows camelCase convention consistent with Objective-C style guidelines
- Correct parameter and return types using GRPCUnaryProtoCall
228-230: LGTM! New Platform2 protocol method is properly declared.The pragma mark and method declaration are consistent with existing patterns and follow proper gRPC Objective-C conventions.
311-313: LGTM! New Platform2 protocol method is properly declared.The method declaration follows established patterns and naming conventions in the file.
319-321: LGTM! New Platform2 protocol method is properly declared.The method declaration is consistent with other methods in the Platform2 protocol interface.
463-467: LGTM! New Platform protocol methods are properly declared.The deprecated-style Platform protocol methods are correctly declared:
- Pragma mark follows established pattern
- Both callback-style and RPC-style methods are provided
- Method signatures are consistent with other methods in the Platform protocol
505-509: LGTM! New Platform protocol methods are properly declared.The method declarations follow the established pattern for the deprecated Platform protocol interface.
674-678: LGTM! New Platform protocol methods are properly declared.The method declarations are consistent with the existing deprecated Platform protocol pattern.
688-692: LGTM! New Platform protocol methods are properly declared.The method declarations follow the established conventions for the deprecated Platform protocol interface.
1-749: Generated code consistency verified.This is an auto-generated Objective-C gRPC client binding file that adds four new RPC methods to the Platform service. The code generation appears consistent:
- Forward declarations match those found in TypeScript bindings for the same message types
- Method naming follows Objective-C camelCase conventions
- Both modern Platform2 protocol and deprecated Platform protocol interfaces are updated consistently
- All new methods follow the established patterns in the file
The additions integrate well with the existing codebase structure.
packages/dapi-grpc/clients/platform/v0/web/platform_pb.d.ts (5)
7363-7456: LGTM: Token contract info response is well‑scoped
TokenContractInfoDataprovidescontractIdandtokenContractPosition, matching the request’s intent. Typings look consistent with the codebase.
8703-8727: LGTM: AddedburnFromIdto BurnEventThe new
burnFromIdfield mirrors other event shapes and improves observability of burner identity. Declarations look consistent.Double‑check that producers populate
burnFromIdand that downstream consumers don’t assume the older 2‑field shape.
3565-3814: LGTM: Finalized epoch info surface looks coherentRequest/response shapes and numeric/string width choices look consistent with adjacent epoch APIs. No issues spotted in the declarations.
Ensure corresponding service stubs were regenerated and exported:
7309-7361: LGTM: Token contract info request shape is minimal and clearRequesting by
tokenIdaligns with the response’s contract resolution. No issues in the declarations.Verify the new RPC is wired in service stubs and re‑exported:
2562-2745: Clarify pagination semantics for non-unique PKH; response lacks cursor/finish indicatorThe request supports
startAfter, implying pagination over potentially multiple identities for a non‑unique PKH, but the response only returns a singleIdentityResponseand provides no cursor orfinishedResultsflag. Clients can’t know if more results exist or how to fetch them.Recommend:
- Either return a list of identities plus a
finishedResultsboolean (or anextStartAftercursor), or- Explicitly make the RPC single‑identity and rename accordingly to avoid confusion, or
- Add a response cursor field for iterative fetching.
Please confirm intended semantics (single vs. multiple results), and if multiple, where the pagination cursor is exposed. If it’s missing in the proto, we should add it and regenerate. Run this to find any docs/usages that assume multi‑item results:
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
New Features
Bug Fixes
Performance
Documentation
Chores