Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use k3s instead of k3d to setup k8s, and test against k8s 1.20-1.23 #518

Merged
merged 1 commit into from Mar 27, 2022

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Mar 27, 2022

By using k3s in our CI setup, we can avoid needing to load images into the k8s container runtime as we would need to if we used k3d. This saves us a minute or so for each kubernetes test we run. It seems that the average time doesn't improve though because it seems using k3d was a bit faster to get started. The k3s the jupyterhub/action-k3s-helm includes calico to help enforce NetworkPolicy resources in a reliable way which the k3d setup didn't provide.

By using the jupyterhub organizations GitHub Action to setup k3s we also get kubectl/helm setup for us. Combied with use of the jupyterhub organizations GitHub Action to provide a report of what has happened within the namespace, we can remove the install-tools.sh script installing kubectl, helm, and stern used to capture misc logs.

Closes #511

@consideRatio consideRatio changed the title ci: use k3s instead of k3d ci: use k3s instead of k3d to setup k8s Mar 27, 2022
@consideRatio consideRatio changed the title ci: use k3s instead of k3d to setup k8s ci: use k3s instead of k3d to setup k8s, and test against k8s 1.20-1.23 Mar 27, 2022
By using k3s in our CI setup, we can avoid needing to load images into
the k8s container runtime as we would need to if we used k3d. This saves
us a minute or so for each kubernetes test we run.

By using the jupyterhub organizations GitHub Action to setup k3s we also
get kubectl/helm setup for us. Combied with use of the jupyterhub
organizations GitHub Action to provide a report of what has happened
within the namespace, we can remove the install-tools.sh script
installing kubectl, helm, and stern used to capture misc logs.
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erik! Always nice to delete code.

@jcrist jcrist merged commit 76f43c0 into dask:main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: kubernetes test intermittently hangs
2 participants