ci: use k3s instead of k3d to setup k8s, and test against k8s 1.20-1.23#518
Merged
ci: use k3s instead of k3d to setup k8s, and test against k8s 1.20-1.23#518
Conversation
2 tasks
By using k3s in our CI setup, we can avoid needing to load images into the k8s container runtime as we would need to if we used k3d. This saves us a minute or so for each kubernetes test we run. By using the jupyterhub organizations GitHub Action to setup k3s we also get kubectl/helm setup for us. Combied with use of the jupyterhub organizations GitHub Action to provide a report of what has happened within the namespace, we can remove the install-tools.sh script installing kubectl, helm, and stern used to capture misc logs.
a9a088a to
4301ef8
Compare
25 tasks
jcrist
approved these changes
Mar 27, 2022
Member
jcrist
left a comment
There was a problem hiding this comment.
Thanks Erik! Always nice to delete code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using k3s in our CI setup, we can avoid needing to load images into the k8s container runtime as we would need to if we used k3d. This saves us a minute or so for each kubernetes test we run. It seems that the average time doesn't improve though because it seems using k3d was a bit faster to get started. The k3s the jupyterhub/action-k3s-helm includes
calicoto help enforce NetworkPolicy resources in a reliable way which the k3d setup didn't provide.By using the jupyterhub organizations GitHub Action to setup k3s we also get kubectl/helm setup for us. Combied with use of the jupyterhub organizations GitHub Action to provide a report of what has happened within the namespace, we can remove the install-tools.sh script installing kubectl, helm, and stern used to capture misc logs.
Closes #511