Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdjusts codecov's target/threshold, disable patch #4671
+5
−2
Conversation
mrocklin
merged commit 631c5a4
into
dask:master
Apr 8, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks @pentschev |
pentschev
deleted the
pentschev:codecov-target-threshold
branch
Apr 17, 2019
asmith26
added a commit
to asmith26/dask
that referenced
this pull request
Apr 22, 2019
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pentschev commentedApr 6, 2019
Solves #4670.
@mrocklin, @jrbourbeau I set target to 90% (we currently meet > 91%) and threshold to 1%. Let me know if you think they're reasonable. I know we don't want to enforce coverage for now, but if it drops by more than 1%, it seems a good idea that we are alerted about that.
flake8 dask