Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts codecov's target/threshold, disable patch #4671

Merged
merged 1 commit into from Apr 8, 2019

Conversation

@pentschev
Copy link
Member

@pentschev pentschev commented Apr 6, 2019

Solves #4670.

@mrocklin, @jrbourbeau I set target to 90% (we currently meet > 91%) and threshold to 1%. Let me know if you think they're reasonable. I know we don't want to enforce coverage for now, but if it drops by more than 1%, it seems a good idea that we are alerted about that.

  • Tests added / passed
  • Passes flake8 dask
@mrocklin mrocklin merged commit 631c5a4 into dask:master Apr 8, 2019
3 checks passed
@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Apr 8, 2019

Thanks @pentschev

@pentschev pentschev deleted the codecov-target-threshold branch Apr 17, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants