Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-8 mathjax breaks gitbook install #31

Closed
ryanlovett opened this issue Nov 18, 2017 · 4 comments
Closed

data-8 mathjax breaks gitbook install #31

ryanlovett opened this issue Nov 18, 2017 · 4 comments

Comments

@ryanlovett
Copy link
Contributor

info: install plugin "mathjax" (git+https://github.com/data-8/plugin-mathjax) from NPM with version git+https://github.com/data-8/plugin-mathjax
make: Entering directory '/gitbook/node_modules/contextify/build'
  CXX(target) Release/obj.target/contextify/src/contextify.o
../src/contextify.cc: In static member function 'static v8::Local<v8::Context> ContextWrap::createV8Context(v8::Local<v8::Object>)':
../src/contextify.cc:150:16: error: 'class v8::ObjectTemplate' has no member named 'SetAccessCheckCallbacks'; did you mean 'SetAccessCheckCallback'?
         otmpl->SetAccessCheckCallbacks(GlobalPropertyNamedAccessCheck,
                ^~~~~~~~~~~~~~~~~~~~~~~
make: *** [Release/obj.target/contextify/src/contextify.o] Error 1
contextify.target.mk:89: recipe for target 'Release/obj.target/contextify/src/contextify.o' failed
make: Leaving directory '/gitbook/node_modules/contextify/build'

The install completes if I swap data-8's mathjax with just "mathjax" in book.json.

@yuvipanda
Copy link
Contributor

Does something more need happening here, @ryanlovett?

@ryanlovett
Copy link
Contributor Author

Its been a while since I looked. #29 had a reproducible workflow at one point. You can drop the issues I filed here if its easier.

@davidwagner
Copy link
Member

Is this still relevant, after Chris's changes to the new Jekyll build process?

@davidwagner
Copy link
Member

I can't reproduce this. Probably moot given the new build process.

matthew-brett added a commit to matthew-brett/textbook that referenced this issue May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants