Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ndonnx #154

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add ndonnx #154

merged 2 commits into from
Jun 25, 2024

Conversation

adityagoel4512
Copy link
Contributor

@adityagoel4512 adityagoel4512 commented Jun 24, 2024

Closes #150.

@adityagoel4512
Copy link
Contributor Author

Closed this since the CI tests as far back as python 3.9, which ndonnx dropped support for in line with https://scientific-python.org/specs/spec-0000/. Changing the minimally supported python version is beyond the scope of this PR.

@asmeurer
Copy link
Member

That's just there to make sure older versions of NumPy work. You should be able to add it to the skips in the CI file.

@adityagoel4512 adityagoel4512 force-pushed the add-ndonnx branch 5 times, most recently from 8015636 to ee061d1 Compare June 24, 2024 23:09
@asmeurer
Copy link
Member

Yes, you can ignore that. I'm fixing it in another PR.

@asmeurer asmeurer merged commit 38ec1d4 into data-apis:main Jun 25, 2024
31 of 35 checks passed
@adityagoel4512 adityagoel4512 deleted the add-ndonnx branch June 25, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ndonnx
2 participants