Skip to content

PERF: Do not use stable sort in nunique #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

PERF: Do not use stable sort in nunique #447

merged 1 commit into from
Sep 30, 2025

Conversation

cakedev0
Copy link
Contributor

@cakedev0 cakedev0 commented Sep 30, 2025 •
edited
Loading

Follow-up to this issue I openend on scikit-learn: scikit-learn/scikit-learn#32283

I ran pixi run tests locally: 5289 passed, 2783 skipped, 117 xfailed, 9 xpassed

lucascolley
lucascolley approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks @cakedev0 !

@lucascolley lucascolley added this to the 0.9.1 milestone Sep 30, 2025
@lucascolley lucascolley merged commit ca20f03 into data-apis:main Sep 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascolley lucascolley lucascolley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cakedev0 @lucascolley