Skip to content

Fix test_iter with Python 3.14 beta 1 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Fix test_iter with Python 3.14 beta 1 #154

merged 1 commit into from
May 16, 2025

Conversation

frenzymadness
Copy link
Contributor

In Python 3.14 beta 1, generator expression returned by the iter method needs to be executed to throw the expected TypeError.

Fixes: #151

@frenzymadness
Fix test_iter with Python 3.14 beta 1
4d23298 
In Python 3.14 beta 1, generator expression returned by the
__iter__ method needs to be executed to throw the expected
TypeError.

Fixes: data-apis#151
@ev-br ev-br added this to the 2.4 milestone May 16, 2025
@ev-br
Copy link
Member

ev-br commented May 16, 2025

Okay, this only changes array-api-strict internal tests, it is reported to fix tests under python 3.14, and the CI confirms it does not affect previous CI versions. It thus looks like a no-brainer to me. Thanks @frenzymadness , it's great to see python 3.14 compliance, even if it's only in an rc phase!

@ev-br ev-br merged commit c74cb9e into data-apis:main May 16, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

Test failure with Python 3.14 beta 1
2 participants
@frenzymadness @ev-br