Skip to content

PR: Add preview in circleCI #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2021
Merged

PR: Add preview in circleCI #8

merged 1 commit into from
Jul 12, 2021

Conversation

steff456
Copy link
Member

@steff456 steff456 commented Jul 8, 2021

This PR enables a preview of the website.

Please note that we need to start the project on circleCI

@steff456 steff456 changed the title PR: Add preview in circle PR: Add preview in circleci Jul 8, 2021
@steff456 steff456 changed the title PR: Add preview in circleci PR: Add preview in circleCI Jul 8, 2021
@rgommers rgommers merged commit 87bef32 into data-apis:main Jul 12, 2021
@rgommers
Copy link
Member

Works well enough: https://1-288051262-gh.circle-artifacts.com/0/public/index.html. Thanks @steff456!

There is a small thing that doesn't work: navigating directly to another page like Blog won't work, because it jumps to blog/ rather than blog/index.html. But going via the CircleCI artifacts page to blog/index.html does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants