Skip to content

remove mention of DataFrame.insert from concat docstring #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Oct 31, 2023

DataFrame.insert has been renamed to DataFrame.assign, and isn't really a complete replacement for horizontal concatenation. I'd suggest just removing the sentence for now, we can always add horizontal concatenation if/when the need arises

@MarcoGorelli MarcoGorelli added the documentation Improvements or additions to documentation label Oct 31, 2023
@MarcoGorelli MarcoGorelli changed the title fix typo in concat docstring remove mention of DataFrame.insert from concat docstring Oct 31, 2023
@kkraus14 kkraus14 merged commit 4d4654b into data-apis:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API design documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants