Skip to content

Consistently use ns for namespace in docs/examples #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

MarcoGorelli
Copy link
Contributor

namespace = dataframe.__dataframe_namespace__() is quite verbose, how about just using a 2-letter acronym in the examples? most people alias namespace to 2-letter acronyms anyway

@rgommers
Copy link
Member

Thanks Marco. This makes sense to me. I was never quite a fan of the namespace name. ns seems better - or something like pdx would work too (we use xp on the array side).

@MarcoGorelli
Copy link
Contributor Author

thanks - yeah thought of pdx too but it struck me as too pandas-centric

@rgommers
Copy link
Member

Makes sense. Let's see if anyone else has a strong opinion - if not, then let's merge within a couple of days.

@kkraus14
Copy link
Collaborator

For what it's worth, I interpret pdx as Python DataFrame X and unrelated to pandas, so I'd be +1 to that. ns makes me think nanoseconds 😆

@MarcoGorelli
Copy link
Contributor Author

thanks all

looks like people are happy with pdx

@MarcoGorelli MarcoGorelli merged commit 4980320 into data-apis:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants