Skip to content

Conversation

fhlavac
Copy link
Contributor

@fhlavac fhlavac commented Sep 3, 2019

closes: #98

  • Added name as a key to tabs component in PF3 and MUI.
  • Modified priority of variables in adding name as a key to tabs component in PF4.
  • Updated documentation of tabs component according to changes made.

@fhlavac fhlavac requested a review from Hyperkid123 September 3, 2019 08:39
@Hyperkid123 Hyperkid123 added docs docs pull requests MUI MUI pull request PF3 PF4 PF4 pull request bug Something isn't working labels Sep 3, 2019
@Hyperkid123
Copy link
Member

@fhlavac fix the failing snapshots please

@codecov-io
Copy link

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files          81       81           
  Lines        1345     1345           
  Branches      318      321    +3     
=======================================
  Hits         1122     1122           
+ Misses        192      190    -2     
- Partials       31       33    +2
Impacted Files Coverage Δ
...kages/mui-component-mapper/src/form-fields/tabs.js 0% <0%> (ø) ⬆️
...kages/pf4-component-mapper/src/form-fields/tabs.js 100% <100%> (ø) ⬆️
...kages/pf3-component-mapper/src/form-fields/tabs.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46a6513...a355572. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 243b306 into data-driven-forms:master Sep 3, 2019
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs docs pull requests MUI MUI pull request PF3 PF4 PF4 pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add name as a key to tabs component
4 participants