Skip to content

Fixing prop-type for FormTemplate #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Conversation

zgover
Copy link
Member

@zgover zgover commented Mar 21, 2021

Description

Fixes error

Warning: Failed prop type: Invalid prop `FormTemplate` of type `object` supplied to `FormRenderer`, expected `function`.

Checklist: (please see documentation page for more information)

  • Yarn build passes
  • Yarn lint passes
  • Yarn test passes
  • Test coverage for new code (if applicable)
  • Documentation update (if applicable)
  • Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

Fixes error:
```
Warning: Failed prop type: Invalid prop `FormTemplate` of type `object` supplied to `FormRenderer`, expected `function`.
```
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #1007 (035a789) into master (2f01b1e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1007   +/-   ##
=======================================
  Coverage   84.79%   84.79%           
=======================================
  Files         199      199           
  Lines        3262     3262           
  Branches     1113     1113           
=======================================
  Hits         2766     2766           
  Misses        496      496           
Impacted Files Coverage Δ
...t-form-renderer/src/form-renderer/form-renderer.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f01b1e...035a789. Read the comment docs.

Copy link
Member

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zgover can you please use this commit message format? fix({scope}): {description}. It will trigger the automatic release. The scope would be renderer.

fix(renderer): Fixed invalid prop-type for FormTemplate and componentMapper.
@Hyperkid123 Hyperkid123 merged commit e205b20 into data-driven-forms:master Mar 21, 2021
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 3.2.1 🎉

The release is available on

Demo can be found here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants