Skip to content

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Sep 3, 2019

Description

flat is causing errors in node environment, it fails tests in consumers applications. So I replaced it by lodash, it is already there.

@rvsia rvsia added the PF4 PF4 pull request label Sep 3, 2019
@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   83.32%   83.32%           
=======================================
  Files          81       81           
  Lines        1349     1349           
  Branches      321      321           
=======================================
  Hits         1124     1124           
  Misses        192      192           
  Partials       33       33
Impacted Files Coverage Δ
...-component-mapper/src/form-fields/wizard/wizard.js 97.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243b306...62303a6. Read the comment docs.

@rvsia rvsia changed the title [WIP] Use lodash for map in PF4 wizard [WIP] Use lodash for flat in PF4 wizard Sep 3, 2019
@rvsia rvsia requested a review from Hyperkid123 September 4, 2019 07:59
@rvsia rvsia changed the title [WIP] Use lodash for flat in PF4 wizard Use lodash for flat in PF4 wizard Sep 4, 2019
@Hyperkid123 Hyperkid123 merged commit 50b70f8 into data-driven-forms:master Sep 6, 2019
@rvsia rvsia deleted the remove-core-js branch September 17, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF4 PF4 pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants