Skip to content

feat(mui): update duallist styling #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Apr 20, 2021

Description

Updates design of MUI Dual List to latest: https://material-ui.com/components/transfer-list/

Screenshot 2021-04-20 at 11 06 22

Schema (if applicable)

{
            fields: [
              {
                component: 'dual-list-select',
                name: 'dual-list-select',
                isFilterable: false,
                checkboxVariant: true,
                leftTitle: '',
                rightTitle: '',
                options: [
                  {
                    value: 'cats',
                    label: 'cats'
                  },
                  {
                    value: 'cats_1',
                    label: 'cats_1'
                  },
                  {
                    value: 'cats_2',
                    label: 'cats_2'
                  },
                  {
                    value: 'zebras',
                    label: 'zebras'
                  },
                  {
                    value: 'pigeons',
                    label: 'pigeons'
                  }
                ]
              }
            ]
          }

@rvsia rvsia added the MUI MUI pull request label Apr 20, 2021
@rvsia rvsia requested a review from Hyperkid123 April 20, 2021 09:08
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1040 (df49ed1) into master (0c5aed1) will increase coverage by 0.02%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   85.26%   85.28%   +0.02%     
==========================================
  Files         201      201              
  Lines        3366     3371       +5     
  Branches     1150     1155       +5     
==========================================
+ Hits         2870     2875       +5     
  Misses        496      496              
Impacted Files Coverage Δ
...nt-mapper/src/dual-list-select/dual-list-select.js 91.66% <77.27%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5aed1...df49ed1. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 594b282 into data-driven-forms:master Apr 20, 2021
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 3.5.0 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the muiDualListUpdate branch June 14, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MUI MUI pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants