Skip to content

fix(common): handle isMulti and null change #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021
Merged

fix(common): handle isMulti and null change #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/common/src/select/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ const handleSelectChange = (option, simpleValue, isMulti, onChange, allOptions,

const sanitizedOption = !enhanceOption && isMulti ? [] : enhanceOption;

if (isMulti && enhanceOption.find(({ selectAll }) => selectAll)) {
if (isMulti && sanitizedOption.find(({ selectAll }) => selectAll)) {
return onChange(allOptions.filter(({ selectAll, selectNone }) => !selectAll && !selectNone).map(({ value }) => value));
}

if (isMulti && enhanceOption.find(({ selectNone }) => selectNone)) {
if (isMulti && sanitizedOption.find(({ selectNone }) => selectNone)) {
return onChange([]);
}

Expand Down
47 changes: 47 additions & 0 deletions packages/common/src/tests/select/select.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,53 @@ describe('Select test', () => {
expect(inputValue).toEqual(['d', 'c']);
});

it('selects null value - clears selection', async () => {
field = { ...field, isMulti: true };

await act(async () => {
wrapper = mount(
<FormRenderer
{...rendererProps}
schema={{
fields: [
{
...field,
component: componentTypes.SELECT,
name: 'select'
}
]
}}
/>
);
});
wrapper.update();

await act(async () => {
wrapper
.find('#onChange')
.props()
.onClick([{ value: 'd' }, { value: 'c' }]);
});
wrapper.update();

expect(state.value).toEqual([
{ label: 'Dogs', value: 'd' },
{ label: 'Cats', value: 'c' }
]);
expect(inputValue).toEqual(['d', 'c']);

await act(async () => {
wrapper
.find('#onChange')
.props()
.onClick(null);
});
wrapper.update();

expect(state.value).toEqual([]);
expect(inputValue).toEqual([]);
});

it('selects all values', async () => {
field = { ...field, isMulti: true, options: [{ label: 'Select all', selectAll: true }, ...field.options] };

Expand Down