Skip to content

fix(renderer): mark onSubmit and FormTemplate as optional props. #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

Hyperkid123
Copy link
Member

Fixes #1229

@Hyperkid123 Hyperkid123 added bug Something isn't working renderer React form renderer PR labels Apr 11, 2022
@Hyperkid123 Hyperkid123 requested a review from rvsia April 11, 2022 07:29
@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.17.1 [DataDrivenFormsBot]

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1230 (e31d53d) into master (2b6ca00) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files         209      209           
  Lines        3612     3612           
  Branches     1261     1261           
=======================================
  Hits         3434     3434           
  Misses        178      178           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rvsia rvsia merged commit e5ab3d2 into master Apr 11, 2022
@rvsia rvsia added the released label Apr 11, 2022
@Hyperkid123 Hyperkid123 deleted the fix-required-props branch May 18, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: issue with typescript types for version 3.17.0
3 participants