Remove isRequired from conditionalSubmitFlag #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new version (fix) will be released: v3.18.4 [DataDrivenFormsBot] |
victoria-dos
force-pushed
the
remove-required
branch
from
5fdf3e4 to
1a12331
Compare
Hyperkid123
approved these changes
Jul 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 209 209
Lines 3623 3623
Branches 1264 1264
=======================================
Hits 3443 3443
Misses 180 180
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
🎉 This PR is included in version 3.18.4 🎉 The release is available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed isRequired from conditionalSubmitFlag because it caused unnecessary warnings.
Checklist: (please see documentation page for more information)
Yarn buildpassesYarn lintpassesYarn testpasses@Hyperkid123