fix(ssr): added global object to renderer and pf4 webpack config. #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperkid123
added
bug
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 83.02% 83.24% +0.22%
==========================================
Files 84 83 -1
Lines 1361 1355 -6
Branches 321 319 -2
==========================================
- Hits 1130 1128 -2
+ Misses 198 195 -3
+ Partials 33 32 -1
Continue to review full report at Codecov.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rvsia can you please build it locally and test if it works with miq and probably some insights version.