Skip to content

fix(ant): pass name to Form.Item #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Jan 10, 2023

Fixes #1353

Description

Passes Input.name to Form.Item to automatically enable htmlFor

Schema

{
   name: 'some-name',
   label: 'some-label'.
   component: 'text-field'
}

@rvsia rvsia added bug Something isn't working ANT labels Jan 10, 2023
@rvsia rvsia requested a review from Hyperkid123 January 10, 2023 14:43
@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.19.1 [DataDrivenFormsBot]

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #1354 (05dd246) into master (d1c1e58) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1354   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files         209      209           
  Lines        3641     3641           
  Branches     1270     1270           
=======================================
  Hits         3463     3463           
  Misses        178      178           
Impacted Files Coverage Δ
...nt-component-mapper/src/date-picker/date-picker.js 100.00% <ø> (ø)
...nt-mapper/src/dual-list-select/dual-list-select.js 75.00% <ø> (ø)
packages/ant-component-mapper/src/select/select.js 87.50% <ø> (ø)
packages/ant-component-mapper/src/switch/switch.js 100.00% <ø> (ø)
.../ant-component-mapper/src/text-field/text-field.js 100.00% <ø> (ø)
...ages/ant-component-mapper/src/textarea/textarea.js 100.00% <ø> (ø)
...nt-component-mapper/src/time-picker/time-picker.js 100.00% <ø> (ø)
.../ant-component-mapper/src/form-group/form-group.js 100.00% <100.00%> (ø)
...r/src/multiple-choice-list/multiple-choice-list.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hyperkid123 Hyperkid123 merged commit f9b7ee6 into data-driven-forms:master Jan 10, 2023
@rvsia rvsia added the released label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANT bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to retrieve a component in ddf through testing-library's *ByLabelText
3 participants