Skip to content

Conversation

Fryguy
Copy link
Contributor

@Fryguy Fryguy commented Oct 4, 2019

@skateman Please review

@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files          87       87           
  Lines        1380     1380           
  Branches      333      333           
=======================================
  Hits         1125     1125           
  Misses        211      211           
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48389e...65cafa0. Read the comment docs.

@skateman
Copy link
Member

skateman commented Oct 4, 2019

Umm ... I'm not JS expert and far from having merge rights into this repo, but yeah, I approve

@skateman
Copy link
Member

skateman commented Oct 7, 2019

@rvsia @Hyperkid123

@Hyperkid123
Copy link
Member

@Fryguy Thank you. I can image there is going to be a lot more of these.

@Hyperkid123
Copy link
Member

@Fryguy in order to trigger release can you please use the semantic release commit message format:

fix(renderer): Commit message // renderer in brackets because it affects the renderer packages

@Fryguy
Copy link
Contributor Author

Fryguy commented Oct 21, 2019

@Hyperkid123 I don't understand what I'm supposed to do, since I did a general find/replace across the codebase. What is the renderer? (This is a drive-by PR, so I'm honestly not sure it even needs changelog or anything)

@rvsia
Copy link
Contributor

rvsia commented Oct 21, 2019

@Fryguy Reword the commit message: Fix typo lenght => length to fix(renderer): Fix typo lenght => length.

Fix will release a new version and renderer (react form renderer) is a scope/package of this PR (see https://data-driven-forms.org/renderer/development-setup#commits )

Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rvsia rvsia merged commit c93b44a into data-driven-forms:master Oct 25, 2019
@Fryguy Fryguy deleted the typo branch August 25, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants