Skip to content

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Oct 16, 2019

Description

Back to the future with PF4 wizard!

  • jumping back on a step with compile mapper will disable jumping forward

  • jumping can be disabled by a prop disableForwardJumping

  • it's opt-in, wizard has to get predictSteps prop to predict the steps in the navigation

  • Adds props

Wizard

Prop Type Default Decription
predictSteps bool undefined If true, dynamic wizard will predict steps in the navigation.

Wizard step

Props Type Decription
disableForwardJumping bool When use return to this step, jumping forward in the navigation is disabled.

Predicting
predicting

Disable jumping forward
disabledJumping

@rvsia rvsia added enhancement New feature or request PF4 PF4 pull request labels Oct 16, 2019
@rvsia rvsia force-pushed the dynamic-wizard-pf4-future branch 4 times, most recently from 368c257 to 0b02ec3 Compare October 17, 2019 10:44
@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #167 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   80.93%   81.16%   +0.22%     
==========================================
  Files          87       87              
  Lines        1364     1370       +6     
  Branches      328      331       +3     
==========================================
+ Hits         1104     1112       +8     
+ Misses        216      214       -2     
  Partials       44       44
Impacted Files Coverage Δ
...-component-mapper/src/form-fields/wizard/wizard.js 100% <100%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9733d38...4ef5241. Read the comment docs.

@rvsia rvsia changed the title [WIP] fix(pf4): predict the future in the wizard nav fix(pf4): predict the future in the wizard nav Oct 17, 2019
@rvsia rvsia force-pushed the dynamic-wizard-pf4-future branch from 092d143 to 4ef5241 Compare October 17, 2019 12:15
@rvsia rvsia changed the title fix(pf4): predict the future in the wizard nav feat(pf4): predict the future in the wizard nav Oct 17, 2019
@rvsia rvsia requested a review from Hyperkid123 October 17, 2019 12:15
Copy link
Member

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Hyperkid123 Hyperkid123 merged commit 91bdf11 into data-driven-forms:master Oct 17, 2019
@rvsia rvsia deleted the dynamic-wizard-pf4-future branch March 5, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PF4 PF4 pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants